Skip to content

Commit

Permalink
bump TestHTTP1DoNotReuseRequestAfterTimeout timeout
Browse files Browse the repository at this point in the history
the test TestHTTP1DoNotReuseRequestAfterTimeout has to wait for
request to time out to assert that subsequent requests does not
reuse the TCP connection.

It seems that current value of 100ms causes issues on some CI
environments and bumping the timeout seems to solve this flakiness,

We can bump the timeout value because is really low compared to real
scenarios and the bump still keeps it in the millisecond order.

Kubernetes-commit: fa68e8248594e54cda4cc06ab69030f6267ebbb7
  • Loading branch information
aojea authored and k8s-publishing-bot committed Nov 29, 2021
1 parent 17bbf03 commit 0d94476
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rest/request_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2995,7 +2995,7 @@ func TestHTTP1DoNotReuseRequestAfterTimeout(t *testing.T) {
config := &Config{
Host: ts.URL,
Transport: utilnet.SetTransportDefaults(transport),
Timeout: 100 * time.Millisecond,
Timeout: 1 * time.Second,
// These fields are required to create a REST client.
ContentConfig: ContentConfig{
GroupVersion: &schema.GroupVersion{},
Expand Down

0 comments on commit 0d94476

Please sign in to comment.