Migrating flags off main.go to a separate package #7890

YahiaBadr · 2025-03-05T14:09:08Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently the flag declaration is coupled with main.go, which should only care about execution.
With this change, we're decoupling flags with main.go, to provide extensibility for cloud-providers to integrate config to execution better.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed deprecated flags:
- max-autoprovisioned-node-group-count -> had a warning and deprecated in 1.31
- node-autoprovisioning-enabled -> had a warning and deprecated in 1.31
- gce-expander-ephemeral-storage-support -> no references, initialized with "_", planned to be removed in 1.30+
- max-empty-bulk-delete -> had a warning  and deprecated in 1.29

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla · 2025-03-05T14:09:12Z

The committers listed above are authorized under a signed CLA.

✅ login: YahiaBadr / name: Yahia Badr (241ad7a, 738d7dd, 3e9d11b, 5751998)

k8s-ci-robot · 2025-03-05T14:09:17Z

Welcome @YahiaBadr!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-03-05T14:09:17Z

Hi @YahiaBadr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

x13n

Nice cleanup, thanks! Just a few minor comments.

x13n · 2025-03-07T12:43:17Z

cluster-autoscaler/config/flags/flags.go

+	}
+
+	if isFlagPassed("max-autoprovisioned-node-group-count") {
+		klog.Warning("The max-autoprovisioned-node-group-count flag is deprecated and will be removed in k8s version 1.31.")


We are approaching 1.33 release, perhaps these flags could be cleaned up?

x13n · 2025-03-07T12:44:13Z

cluster-autoscaler/config/flags/flags.go

+	}
+
+	if isFlagPassed("node-autoprovisioning-enabled") {
+		klog.Warning("The node-autoprovisioning-enabled flag is deprecated and will be removed in k8s version 1.31.")


We are approaching 1.33 release, perhaps these flags could be cleaned up?

sure, what about the UpdateNapEnabled metric, should we remove it as well?

Yup, I don't think it makes sense to keep a metric based on a deprecated flag.

x13n · 2025-03-07T12:51:50Z

cluster-autoscaler/config/flags/flags.go

+	cloudBuilder "k8s.io/autoscaler/cluster-autoscaler/cloudprovider/builder"
+	"k8s.io/autoscaler/cluster-autoscaler/cloudprovider/gce/localssdsize"
+	"k8s.io/autoscaler/cluster-autoscaler/config"
+	"k8s.io/autoscaler/cluster-autoscaler/core/scaledown/actuation"


Do we need to depend on actuation module? Looks like the only function used is some flag parsing util, perhaps it could be refactored a bit?

good point, yeah i think we can include it in flags.go aside to the other parsing functions

x13n

Thanks, just two minor comments.

x13n · 2025-03-10T13:55:10Z

cluster-autoscaler/config/autoscaling_options.go

+	DebuggingSnapshotEnabled bool
+	// EnableProfiling is debug/pprof endpoint enabled.
+	EnableProfiling bool
+	// Address is the address to expose prometheus metrics.


Not just prometheus - also healthchecks & profiles. Can you update the comment to something more generic that will reflect current usage?

x13n · 2025-03-10T13:56:49Z

cluster-autoscaler/config/autoscaling_options.go

 	// It only refers to check capacity ProvisioningRequests, but if not empty, best-effort atomic ProvisioningRequests processing is disabled in this instance.
 	// Not recommended: Until CA 1.35, ProvisioningRequests with this name as prefix in their class will be also processed.
 	CheckCapacityProcessorInstance string
+	// MaxInactivityTime is the maximum time from last recorded autoscaler activity before automatic restart.


nit: MaxInactivityTime / MaxFailingTime don't control restarts directly, only healthchecks.

x13n · 2025-03-10T14:28:13Z

Thanks!

/lgtm
/approve

k8s-ci-robot · 2025-03-10T14:28:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x13n, YahiaBadr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cluster-autoscaler/OWNERS~~ [x13n]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 5, 2025

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 5, 2025

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/cluster-autoscaler labels Mar 5, 2025

k8s-ci-robot requested review from BigDarkClown and feiskyer March 5, 2025 14:09

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 5, 2025

x13n requested changes Mar 7, 2025

View reviewed changes

YahiaBadr added 3 commits March 7, 2025 21:11

Migrating flags off main.go to a separate package

3e9d11b

Migrating flags off main.go to a separate package

5751998

Migrating flags off main.go to a separate package

738d7dd

YahiaBadr force-pushed the migrate-flags-off-main branch 2 times, most recently from e8f526a to ea799d3 Compare March 10, 2025 13:25

YahiaBadr requested a review from x13n March 10, 2025 13:34

x13n reviewed Mar 10, 2025

View reviewed changes

update address description

241ad7a

YahiaBadr force-pushed the migrate-flags-off-main branch from ea799d3 to 241ad7a Compare March 10, 2025 14:26

YahiaBadr requested a review from x13n March 10, 2025 14:26

k8s-ci-robot assigned x13n Mar 10, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025

k8s-ci-robot merged commit e1e1c32 into kubernetes:master Mar 10, 2025
6 checks passed

Migrating flags off main.go to a separate package #7890

Migrating flags off main.go to a separate package #7890

Uh oh!

Conversation

YahiaBadr commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

linux-foundation-easycla bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 5, 2025

Uh oh!

k8s-ci-robot commented Mar 5, 2025

Uh oh!

x13n left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

x13n left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

x13n commented Mar 10, 2025

Uh oh!

k8s-ci-robot commented Mar 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YahiaBadr commented Mar 5, 2025 •

edited

Loading

linux-foundation-easycla bot commented Mar 5, 2025 •

edited

Loading