Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.29] Add flag to enable fast delete of failed VMSS #7375

Open
wants to merge 1 commit into
base: cluster-autoscaler-release-1.29
Choose a base branch
from

Conversation

willie-yao
Copy link

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

"Refactor" as a part of fork-upstream realignment. Fork introduces an environment variable AZURE_ENABLE_FAST_DELETE_ON_FAILED_PROVISIONING to enable fast delete of failed VMSS, whereas upstream does this by default.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Question: should this be enabled by default to preserve current behavior upstream?

Add flag to enable fast delete of failed VMSS

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider labels Oct 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2024
@willie-yao
Copy link
Author

/assign @comtalyst

@willie-yao willie-yao force-pushed the fast-delete-1.29 branch 2 times, most recently from 6fbf790 to 0f924f8 Compare October 10, 2024 21:44
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2024
@jackfrancis
Copy link
Contributor

@willie-yao is there a reason we're merging this directly into the 1.29 release branch as opposed to landing in main and then backporting to the desired release branches?

@willie-yao
Copy link
Author

@jackfrancis The fast delete that exists in upstream is only on 1.28+ and is also handled differently across versions. I also observed other deforking PRs merging directly into a release branch.

@jackfrancis
Copy link
Contributor

@willie-yao makes sense

Are we able to classify this change in a semver-agreeable manner that would be appropriate for a future patch release? (i.e., bug)

@willie-yao
Copy link
Author

I wouldn't call this a bug and I see other defork-related PRs just titled as "chore". Would that be sufficient? Not sure if defork cleanup can be a special case as a patch release item, but I just wanna keep things consistent.

@willie-yao willie-yao changed the title chore: Add flag to enable fast delete of failed VMSS [release-1.29] Add flag to enable fast delete of failed VMSS Oct 16, 2024
@willie-yao willie-yao force-pushed the fast-delete-1.29 branch 4 times, most recently from af84208 to 2711acc Compare October 31, 2024 21:45
@comtalyst
Copy link
Contributor

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: comtalyst, rakechill, willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@comtalyst
Copy link
Contributor

It is something in between a bug and an improvement.
The nature of the issue is that some failed VMs won't get deleted fast enough. It could be argued that it is supposed to. Thus, this flag should contain an experimental method to deal with that.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@comtalyst
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 11, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants