-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.29] Add flag to enable fast delete of failed VMSS #7375
base: cluster-autoscaler-release-1.29
Are you sure you want to change the base?
[release-1.29] Add flag to enable fast delete of failed VMSS #7375
Conversation
/assign @comtalyst |
6fbf790
to
0f924f8
Compare
@willie-yao is there a reason we're merging this directly into the 1.29 release branch as opposed to landing in main and then backporting to the desired release branches? |
@jackfrancis The fast delete that exists in upstream is only on 1.28+ and is also handled differently across versions. I also observed other deforking PRs merging directly into a release branch. |
@willie-yao makes sense Are we able to classify this change in a semver-agreeable manner that would be appropriate for a future patch release? (i.e., bug) |
I wouldn't call this a bug and I see other defork-related PRs just titled as "chore". Would that be sufficient? Not sure if defork cleanup can be a special case as a patch release item, but I just wanna keep things consistent. |
dfb8357
to
c977e47
Compare
af84208
to
2711acc
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: comtalyst, rakechill, willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It is something in between a bug and an improvement. |
2711acc
to
c897c09
Compare
/lgtm |
c897c09
to
66b9345
Compare
New changes are detected. LGTM label has been removed. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
"Refactor" as a part of fork-upstream realignment. Fork introduces an environment variable
AZURE_ENABLE_FAST_DELETE_ON_FAILED_PROVISIONING
to enable fast delete of failed VMSS, whereas upstream does this by default.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Question: should this be enabled by default to preserve current behavior upstream?