-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting init containers for cluster-autoscaler #7267
base: master
Are you sure you want to change the base?
feat: allow setting init containers for cluster-autoscaler #7267
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hegerdes The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @hegerdes! |
Hi @hegerdes. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
15f159e
to
c0518bf
Compare
c0518bf
to
8322724
Compare
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
8322724
to
1d5d54e
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
It adds the ability to run init (and sidecar) containers within the cluster-autoscaler deployment when installing via helm. A lot of providers depend on configuration options and files depending on their cloud provider. A init container or sidecar container would allow to execute any logic in order to get or create the autoscaler provider configuration dynamically.
Which issue(s) this PR fixes:
Fixes #
Not existing yet
Special notes for your reviewer:
Example and test usage:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: