Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate patch release schedule #6346

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Regenerate patch release schedule #6346

merged 3 commits into from
Dec 29, 2023

Conversation

x13n
Copy link
Member

@x13n x13n commented Dec 5, 2023

Schedule based on https://kubernetes.io/releases/patch-releases/#upcoming-monthly-releases. Included more rows to have one entry per maintainer.

What type of PR is this?

/kind documentation

@gjtempleton @BigDarkClown @towca PTAL

Schedule based on https://kubernetes.io/releases/patch-releases/#upcoming-monthly-releases. Included more rows to have one entry per maintainer.
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2023
@x13n
Copy link
Member Author

x13n commented Dec 8, 2023

/assign @gjtempleton @BigDarkClown @towca

@towca
Copy link
Collaborator

towca commented Dec 8, 2023

/lgtm
/hold

The schedule LGTM, are the question marks intended? Maybe we can just leave the month? Hard to predict the exact day so far in the future.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 8, 2023
@gjtempleton
Copy link
Member

Same question on the question marks as @towca though, giving an idea of at least the week we intend to cut the release makes it easier for us to give cut-offs for PRs people want to make the releases in advance.

Added concrete dates for future patch releases.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2023
@x13n
Copy link
Member Author

x13n commented Dec 15, 2023

Ok, added some tentative dates (second-to-last Wed each month). Should be good enough for now and we can adjust later if needed.

@x13n
Copy link
Member Author

x13n commented Dec 18, 2023

@gjtempleton @BigDarkClown @towca PTAL

@x13n
Copy link
Member Author

x13n commented Dec 18, 2023

Also @MaciekPytel - since you're added as backup in the 2024-09 release.

@gjtempleton
Copy link
Member

Looks good to me.

One other thought I've had given the release of 1.29 over the weekend is whether we want to also set up a schedule for cutting the .0 releases for new versions of kubernetes?

@MaciekPytel
Copy link
Contributor

/lgtm

I see no reason for not adding a schedule for minor releases (.0 versions).
The only limitation is that I think k8s only publishes the timelines for the next release I think (?), so we may not be able to put specific dates. But a table mapping version to maintainer (e.g. 1.29.0 -> MaciekPytel) should be sufficient I think.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2023
| 2024-01-17 | MaciekPytel | gjtempleton |
| 2024-03-13 | gjtempleton | BigDarkClown |
| 2024-05-22 | BigDarkClown | towca |
Copy link
Contributor

@MaciekPytel MaciekPytel Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment - would you mind swapping backup shifts @towca? I would take this one and you'd take the one in September.
My 10th marriage anniversary is in September and I estimate a very high chance that I will take some vacation to travel at this time :)

(edit: this shouldn't block this PR, we can figure out the details with @towca and update the schedule in a follow-up PR)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After including minor releases this is no longer an issue, your anniversary travel plans have been de-risked now :)

Include minor releases in the release schedule.
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 28, 2023
@x13n
Copy link
Member Author

x13n commented Dec 28, 2023

We don't have specific dates for patches either, so all of them are approximate. Included minor versions in the schedule as well, PTAL.

@gjtempleton
Copy link
Member

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2023
@x13n
Copy link
Member Author

x13n commented Dec 29, 2023

Thanks! This has been hanging for a while now, so let's merge and address any concerns in follow up PRs if needed.

/label tide/merge-method-squash
/unhold

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9521a0f into master Dec 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants