Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cluster-autoscaler CAPI provider owners #4200

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Jul 15, 2021

This change is adding github users arunmk, mrajashree, jackfrancis, and shysank
to the reviews for the cluster-api provider. It also removes frobware
from the approvers and reviewers.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jul 15, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Jul 15, 2021

cc @detiber @frobware @arunmk @mrajashree @jackfrancis

@elmiko
Copy link
Contributor Author

elmiko commented Jul 15, 2021

gonna give @mrajashree a chance to get the kube org application completed

@elmiko
Copy link
Contributor Author

elmiko commented Jul 15, 2021

updated to add @shyshank as well

@elmiko
Copy link
Contributor Author

elmiko commented Jul 15, 2021

oops, meant to be @shysank

@mrajashree
Copy link

gonna give @mrajashree a chance to get the kube org application completed

thanks @elmiko 🙏
kubernetes/org#2833

This change is adding github users arunmk, mrajashree, jackfrancis,
shysank, and randomvariable to the reviews for the cluster-api
provider. It also removes frobware and ncdc from the approvers and
reviewers.
@elmiko
Copy link
Contributor Author

elmiko commented Jul 15, 2021

updated to add @randomvariable and remove @ncdc

@randomvariable
Copy link
Member

/verify-owners

@hardikdr
Copy link
Member

Hmm, the application PR kubernetes/org#2834 is merged but I don't see @mrajashree as part of the org yet. - https://github.com/orgs/kubernetes/people?query=mrajashree
Maybe we wait a little more.

@mrajashree
Copy link

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 16, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Jul 16, 2021

we'll see if this works
/lgtm

@k8s-ci-robot
Copy link
Contributor

@elmiko: you cannot LGTM your own PR.

In response to this:

we'll see if this works
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor Author

elmiko commented Jul 16, 2021

ah well, i tried.

@enxebre @detiber @hardikdr ptal

@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit d74c8e3 into kubernetes:master Jul 16, 2021
@elmiko elmiko deleted the update-capi-owners branch July 19, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants