fix: properly parse azure cloud provider config #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @feiskyer |
marwanad
force-pushed
the
fix-azure-cloud-config-parsing
branch
from
b348f68
to
cf044ae
Compare
marwanad
force-pushed
the
fix-azure-cloud-config-parsing
branch
from
cf044ae
to
eebb33e
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@marwanad Thanks for the fix. /area provider/azure |
k8s-ci-robot
added
area/provider/azure
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 19, 2019
Cherry pick #2661 to 1.14: fix: properly parse azure cloud provider config
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure cloud provider config files aren't INI-formatted so the initial parsing logic would fail