clusterIP: "{{ .Values.service.clusterIP }}" not define in values

[marcossilvestrini]

Hi.

I find a error in to definitions of templates and values.

{{- if .Values.service.clusterIP }}
clusterIP: "{{ .Values.service.clusterIP }}"
{{- end }}

This key\value is not define in values.yaml

Values:

autoscaler/charts/cluster-autoscaler/values.yaml

Line 328 in 2c2128e

service:

Template:

autoscaler/charts/cluster-autoscaler/templates/service.yaml

Line 17 in 2c2128e

{{- if .Values.service.clusterIP }}

[gjtempleton]

/good-first-issue
/kind bug

[k8s-ci-robot]

@gjtempleton:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Shubham82]

/triage accepted

[Shubham82]

We also have to update the link for External IPs, present under the comment as a reference.

Line to update:

autoscaler/charts/cluster-autoscaler/values.yaml

Line 335 in 2c2128e

# service.externalIPs -- List of IP addresses at which the service is available. Ref: https://kubernetes.io/docs/user-guide/services/#external-ips.

Current Link: https://kubernetes.io/docs/user-guide/services/#external-ips
Updated Link: https://kubernetes.io/docs/concepts/services-networking/service/#external-ips

[TronSkywalker]

I cannot reproduce a bug or error for the not defined clusterID,
shouldn't this then be kind/cleanup?

Will provide PR if I may pick this issue up. (Will include your comment #6631 (comment))

[jackfrancis]

Hi @marcossilvestrini , in fact this is not really a bug. The fact that we don't declare a default in the values.yaml of the chart doesn't mean we can't use it in the template. For example:

$ helm template cas cluster-autoscaler --set service.clusterIP="10.0.0.10" | grep 'kind: Service$' -A10
kind: Service
metadata:
  labels:
    app.kubernetes.io/instance: "cas"
    app.kubernetes.io/name: "aws-cluster-autoscaler"
    app.kubernetes.io/managed-by: "Helm"
    helm.sh/chart: "cluster-autoscaler-9.40.0"
  name: cas-aws-cluster-autoscaler
  namespace: default
spec:
  clusterIP: "10.0.0.10"

As described here, there are three ways to input values to be interpreted by the helm template, only one of which is via the values.yaml file.

You could argue that it is a best-practice to include a default in the values.yaml, and more importantly because we're using helm-docs to auto-generate helm values documentation, we should include it there and then re-gen documentation. We can call that a cleanup item.

[Shubham82]

JFI: I have raised a new PR #7452 to fix this issue.