Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten helm keys common, daemonset. Add CHANGELOG file for the helm chart #393

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Flatten helm keys common, daemonset. Add CHANGELOG file for the helm chart #393

merged 2 commits into from
Jul 21, 2023

Conversation

mauriciopoppe
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind cleanup
/kind feature

What this PR does / why we need it:
For the v2 version of the chart let's flatten some of the nested properties.

Testing:

  • After the refactor I run ./hack/verify-generated.sh and there were no changes in the generated manifests.

Release note:

Helm Chart values flattened when possible, please check the CHANGELOG.md file inside the helm/ directory

/cc @stevehipwell
/assign @msau42

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 21, 2023
msau42
msau42 reviewed Jul 21, 2023
View reviewed changes
helm/README.md Outdated Show resolved Hide resolved
@mauriciopoppe mauriciopoppe force-pushed the flatten-helm-values branch 2 times, most recently from 2e28807 to 7cc6fa0 Compare July 21, 2023 17:55
@msau42
Copy link
Contributor

msau42 commented Jul 21, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mauriciopoppe, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mauriciopoppe,msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b32722e into kubernetes-sigs:master Jul 21, 2023
6 checks passed
@mauriciopoppe mauriciopoppe mentioned this pull request Jul 21, 2023
Merged
@stevehipwell stevehipwell mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@stevehipwell stevehipwell Awaiting requested review from stevehipwell

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauriciopoppe @msau42 @k8s-ci-robot