Skip to content

Conversation

@eyenx
Copy link
Contributor

@eyenx eyenx commented Sep 5, 2025

Adding OpenBao as Provider

/kind feature

What this PR does / why we need it:

Adding OpenBao as provider including tests.

Which issue(s) this PR fixes
Fixes #1580

Special notes for your reviewer:
mostly inspired by the vault provider tests https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/main/test/bats/vault.bats credits to @sozercan @aramase @ritazh and the rest of the community!

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @eyenx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eyenx
Once this PR has been reviewed and has the lgtm label, please assign ritazh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 5, 2025
Signed-off-by: Toni Tauro <toni.tauro@secretz.io>
@eyenx eyenx force-pushed the feat/add-openbao-as-provider branch from 5dc1c60 to 9a74fa4 Compare September 5, 2025 07:19
@enj enj moved this to Subprojects - Needs Triage in SIG Auth Sep 5, 2025
@enj enj added this to SIG Auth Sep 5, 2025
@JoeMurray
Copy link

I've created a separate PR #1914 that goes with this one.

@eyenx
Copy link
Contributor Author

eyenx commented Sep 25, 2025

Friendly Bump to @ritazh and @aramase

@JoeMurray
Copy link

@aramase or @ritazh I'm wondering if you could indicate the process/timeline when this PR may get a review. I see @aramase has committed to this repo in the last month, but the CSI Secrets Store project meetings are tailing off https://docs.google.com/document/d/1q74nboAg0GSPcom3kLWCIoWg43Qg3mr306KNL58f2hg/edit?tab=t.0

@aramase
Copy link
Member

aramase commented Oct 16, 2025

@aramase or @ritazh I'm wondering if you could indicate the process/timeline when this PR may get a review. I see @aramase has committed to this repo in the last month, but the CSI Secrets Store project meetings are tailing off https://docs.google.com/document/d/1q74nboAg0GSPcom3kLWCIoWg43Qg3mr306KNL58f2hg/edit?tab=t.0

@JoeMurray please give a couple of weeks for review, the maintainers are currently working on the Kubernetes v1.35 release.

While you wait for review, please also open a PR to add an optional job in https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml for the new provider, so the changes in this PR can be validated. Please ping me on the PR when it's available and I can review it soon to unblock testing on this one.

@aramase
Copy link
Member

aramase commented Nov 3, 2025

/retitle test: add e2e for openbao csi provider

@k8s-ci-robot k8s-ci-robot changed the title Feat/add openbao as provider test: add e2e for openbao csi provider Nov 3, 2025
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyenx As a first step, Please open a PR in test-infra, similar to kubernetes/test-infra#32573, to add an optional job so these tests can be validated.

Also, please revert the doc changes in this PR. We can update the docs after the tests are passing and merged.

@github-project-automation github-project-automation bot moved this from Subprojects - Needs Triage to Changes Requested in SIG Auth Nov 3, 2025
@aramase
Copy link
Member

aramase commented Nov 3, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2025
@aramase aramase mentioned this pull request Nov 3, 2025
3 tasks
@eyenx
Copy link
Contributor Author

eyenx commented Nov 27, 2025

@eyenx As a first step, Please open a PR in test-infra, similar to kubernetes/test-infra#32573, to add an optional job so these tests can be validated.

Also, please revert the doc changes in this PR. We can update the docs after the tests are passing and merged.

Hi @aramase

Thanks for the hint. I will try to get this done in December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Support OpenBao as a spec.provider in secrets-store.csi.x-k8s.io/v1

4 participants