-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of OpenAPI descriptions #365
Improve handling of OpenAPI descriptions #365
Conversation
Welcome @robert-cronin! |
/retitle Improve handling of OpenAPI descriptions |
2d40fad
to
7a2e14e
Compare
9b02c31
to
8487ec2
Compare
Now with the goldmark parser, we've made progress: I believe we will still need kubernetes/kube-openapi#482 in order to have the code render correctly with line breaks. |
/approve Please resolve the conflicts ... |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robert-cronin, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The line breaks are defects in the upstream source code comments. I don't think we need to |
8487ec2
to
01b1bb8
Compare
Thank you for the approve @tengqm, I've resolved the conflicts and rebased onto master. |
/lgtm |
Details can be found at: kubernetes/website#47089