Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add special case operation names #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add special case operation names #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions gen-apidocs/config/v1_30/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,10 @@ operation_categories:
match: proxy${group}${version}PUT(Namespaced)?${resource}
- name: Replace Proxy Path
match: proxy${group}${version}PUT(Namespaced)?${resource}WithPath
- name: Patch Proxy
match: connect${group}${version}Patch(Namespaced)?${resource}Proxy
- name: Patch Proxy Path
match: connect${group}${version}Patch(Namespaced)?${resource}ProxyWithPath
- name: "Misc Operations"
default: true
operation_types:
Expand All @@ -330,21 +334,20 @@ operation_categories:
match: connect${group}${version}Get(Namespaced)?${resource}Attach
- name: Create Connect Attach
match: connect${group}${version}Post(Namespaced)?${resource}Attach
- name: Replace Namespace Finalize
match: replace${group}${version}(Namespaced)?${resource}Finalize
- name: Read Approval
match: read${group}${version}(Namespaced)?${resource}Approval
- name: Patch Approval
match: patch${group}${version}(Namespaced)?${resource}Approval
- name: Replace Approval
match: replace${group}${version}(Namespaced)?${resource}Approval

# List of *partial* operation IDs for matching. All matched operations are
# excluded from the reference doc.
excluded_operations:
- connectCoreV1Patch
- createCoreV1NamespacedPodBinding
- getCodeVersion
- logFileHandler
- logFileListHandler
Comment on lines -339 to -341
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify whether these operations are properly supported and thus should not be excluded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getCodeVersion: This seems to get the Kubernetes code version as intended
logFileHandle, logFileListHandler: Good catch, these are not supported

- replaceCoreV1NamespaceFinalize
- V1beta1CertificateSigningRequestApproval
- V1CertificateSigningRequestApproval
- V1beta1NamespacedReplicationControllerDummyScale
- getServiceAccountIssuerOpenIDConfiguration
- getServiceAccountIssuerOpenIDKeyset
- logFileHandler
- logFileListHandler

# Map from group name to its full name
group_full_names:
Expand Down