Introduce nfd client for image compatibilty

[mfranczy]

The PR provides an initial implementation of #1845. Image compatibility is defined by Node Feature Rules, so a change was also necessary there. A run strategy pattern has been implemented to control rule execution, allowing either all rules to be executed or stopping at the first failure.

The work is still in progress but is ready for the first review round.
Remaining tasks:
- [x] write unit tests
- [x] write documentation and add appropriate code comments
- [x] refine the commands

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mfranczy
Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @mfranczy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	cf7b0ba
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/673c709936d6ec0008c5ee13
😎 Deploy Preview	https://deploy-preview-1932--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ArangoGutierrez]

/ok-to-test

[ArangoGutierrez]

@marquiz PTAL

[mfranczy]

/retest

[ChaoyiHuang]

Additionally, I’m including a sample output from the nfd compat validate-node.. cmd

I belive this first implementation is good enough to be included in v0.17.0 release.

if matched features can be returned and output correctly, then all other unmatched feature should be failure in feature matching.

so maybe no need to introduce runstrategy, just in the output, for the features not in the matched feature list(but in the compatibility yaml), tag it as failed.

then we may get same report as that with runstrategy

[mfranczy]

Additionally, I’m including a sample output from the nfd compat validate-node.. cmd
I belive this first implementation is good enough to be included in v0.17.0 release.

if matched features can be returned and output correctly, then all other unmatched feature should be failure in feature matching.

The current rules implementation doesn’t easily match executed features (whether failed or succeeded) with expressions in the spec, as it was not designed for that. Without changes, validate-node would need overly complex algorithms. Starting a full refactor now risks delaying inclusion in v0.17, so it’s better to start small. Additionally, I would like to discuss the planned changes with @marquiz first.

so maybe no need to introduce runstrategy, just in the output, for the features not in the matched feature list(but in the compatibility yaml), tag it as failed.
then we may get same report as that with runstrategy

A run strategy implementation is required because, by default, rule processing stops at the first failure. validate-node must process all the rules.

[mfranczy]

The current rules implementation doesn’t easily match executed features (whether failed or succeeded) with expressions in the spec, as it was not designed for that. Without changes, validate-node would need overly complex algorithms. Starting a full refactor now risks delaying inclusion in v0.17, so it’s better to start small. Additionally, I would like to discuss the planned changes with @marquiz first.

After discussions with end users, it became clear that the minimal functionality wasn't sufficient, so I revisited the problem from a new perspective.

Previously, I attempted to handle expression execution status similar to MatchedFeatures, which introduced significant complexity and required extensive changes to the NFR code. I found a better approach by extending the expression struct with an isMatch field, allowing the expression status to update directly during processing.

@ArangoGutierrez @marquiz apologies for the multiple updates, but this is the final version. The PR is ready for review, and I consider it complete. Please review whenever you have a moment. This commit shows the changes to NFR code.

Example output from the validate-node command:

[mfranczy]

/retest

[mfranczy]

/retest

[mfranczy]

/retest