Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfd-master: Add status for NodeFeatureRule CRD #1901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nfd-master: Add status for NodeFeatureRule CRD #1901

wants to merge 1 commit into from

Conversation

ozhuraki
Copy link
Contributor

@ozhuraki ozhuraki commented Oct 6, 2024

Closes: #1072

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 6, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 6, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit cb5a902
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6720cce2152536000801ba69
😎 Deploy Preview https://deploy-preview-1901--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ArangoGutierrez
ArangoGutierrez requested changes Oct 9, 2024
View reviewed changes
api/nfd/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/nfd-master/nfd-master.go Show resolved Hide resolved
@ozhuraki ozhuraki force-pushed the crd-rule branch 2 times, most recently from 0573dbb to 09c8ef0 Compare October 22, 2024 16:18
@ozhuraki
Copy link
Contributor Author

@ArangoGutierrez

Thanks for the input. Take a look, please if this would address extra updates?

@ArangoGutierrez
Copy link
Contributor

/assign @marquiz
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ozhuraki
Once this PR has been reviewed and has the lgtm label, please ask for approval from marquiz. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozhuraki
nfd-master: Add status for NodeFeatureRule CRD
cb5a902 
Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fmuyassarov
fmuyassarov reviewed Nov 6, 2024
View reviewed changes
api/nfd/v1alpha1/types.go
@@ -131,6 +131,8 @@ type NodeFeatureRule struct {

// Spec defines the rules to be evaluated.
Spec NodeFeatureRuleSpec `json:"spec"`
// +optional
Status NodeFeatureRuleStatus `json:"status"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Status NodeFeatureRuleStatus `json:"status"`
Status NodeFeatureRuleStatus `json:"status,omitempty"`

api/nfd/v1alpha1/types.go
Comment on lines +151 to +152
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t need to include metadata in the Status, as it doesn't add any additional value there.

api/nfd/v1alpha1/types.go
metav1.ObjectMeta `json:"metadata,omitempty"`

// +optional
Rules []RuleStatus `json:"rules"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Rules []RuleStatus `json:"rules"`
Rules []RuleStatus `json:"rules,omitempty"`

api/nfd/v1alpha1/types.go
Comment on lines +148 to +149
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// +genclient
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These markers were replaced by kubebuilder:object:root=true. So, we could drop this off too. Reference: https://book.kubebuilder.io/migration/legacy/migration_guide_v1tov2.html?highlight=genclient#migrate-the-apis

api/nfd/v1alpha1/types.go
Comment on lines +146 to +147
// +kubebuilder:resource:scope=Namespaced,shortName=nfs
// +kubebuilder:subresource:status
Copy link
Member

@fmuyassarov fmuyassarov Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be organized under the parent object NodeFeatureRule. Since they already exist, you could just drop them. You can find the relevant section here:

node-feature-discovery/api/nfd/v1alpha1/types.go

Line 123 in 955095c

// +kubebuilder:object:root=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@kad kad Awaiting requested review from kad

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@marquiz marquiz

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status for NodeFeatureRule CRD
5 participants
@ozhuraki @k8s-ci-robot @ArangoGutierrez @fmuyassarov @marquiz