Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: Add revision history limit for worker daemonset #1797

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Helm: Add revision history limit for worker daemonset #1797

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63e45fc
Helm: Add revision history limit for worker daemonset
rouke-broersma Jul 17, 2024
8e22dec
Helm: Add revision history limit for topology updater daemonset
rouke-broersma Jul 17, 2024
d48aee0
Merge branch 'master' into revision-history-limit-worker-daemonset
rouke-broersma Jul 18, 2024
2f0f7a8
chore: tidy table columns
rouke-broersma Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deployment/helm/node-feature-discovery/templates/worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
revisionHistoryLimit: {{ .Values.worker.revisionHistoryLimit }}
selector:
matchLabels:
{{- include "node-feature-discovery.selectorLabels" . | nindent 6 }}
Expand Down
3 changes: 3 additions & 0 deletions deployment/helm/node-feature-discovery/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,9 @@ worker:
# If not set and create is true, a name is generated using the fullname template
name:

# specify how many old ControllerRevisions for the DaemonSet to retain.
revisionHistoryLimit:

rbac:
create: true

Expand Down
1 change: 1 addition & 0 deletions docs/deployment/helm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ API's you need to install the prometheus operator in your cluster.
| `worker.annotations` | dict | {} | NFD worker pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
| `worker.daemonsetAnnotations` | dict | {} | NFD worker daemonset [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
| `worker.args` | array | [] | Additional [command line arguments](../reference/worker-commandline-reference.md) to pass to nfd-worker |
| `worker.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) |

### Topology updater parameters

Expand Down