add ARMv7 support #1659

Links2004 · 2024-04-06T09:03:14Z

this allows the nfd to run on arm devices like the Raspberry Pi >= 2
with ARMv7 core or ARMv8 in 32Bit mode

linux-foundation-easycla · 2024-04-06T09:03:18Z

The committers listed above are authorized under a signed CLA.

✅ login: Links2004 / name: Markus (8acff5e)

k8s-ci-robot · 2024-04-06T09:03:23Z

Welcome @Links2004!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-04-06T09:03:23Z

Hi @Links2004. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2024-04-06T09:03:30Z

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	`8acff5e`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/661d3dcd5cf189000819f669
😎 Deploy Preview	https://deploy-preview-1659--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Links2004 · 2024-04-06T09:04:52Z

local build via

make image-all

is working, test image can be found here: https://github.com/users/Links2004/packages/container/node-feature-discovery/200401656?tag=v0.16.0-devel-132-g1696c658-dirty-minimal

ArangoGutierrez · 2024-04-08T10:05:25Z

Makefile

@@ -63,7 +63,7 @@ BUILD_FLAGS = -tags osusergo,netgo \
              -ldflags "-s -w -extldflags=-static -X sigs.k8s.io/node-feature-discovery/pkg/version.version=$(VERSION) -X sigs.k8s.io/node-feature-discovery/pkg/utils/hostpath.pathPrefix=$(HOSTMOUNT_PREFIX)"

 # multi-arch build with buildx
-IMAGE_ALL_PLATFORMS ?= linux/amd64,linux/arm64
+IMAGE_ALL_PLATFORMS ?= linux/amd64,linux/arm64,linux/arm/v7


Suggested change

IMAGE_ALL_PLATFORMS ?= linux/amd64,linux/arm64,linux/arm/v7

IMAGE_ALL_PLATFORMS ?= linux/amd64,linux/arm64,linux/arm32v7

As seen at https://docs.docker.com/build/building/multi-platform/

the link show it with linux/arm/v7

e.g. --platform linux/amd64,linux/arm64,linux/arm/v7

and my local system shows it the same when running docker buildx ls.

# docker buildx ls NAME/NODE DRIVER/ENDPOINT STATUS BUILDKIT PLATFORMS default* docker \_ default \_ default running v0.13.1 linux/amd64, linux/amd64/v2, linux/amd64/v3, linux/amd64/v4, linux/386, linux/arm64, linux/riscv64, linux/ppc64, linux/ppc64le, linux/s390x, linux/mips64le, linux/mips64, linux/loong64, linux/arm/v7, linux/arm/v6

ArangoGutierrez · 2024-04-08T11:13:16Z

/ok-to-test

ArangoGutierrez

cc @marquiz for lgtm

marquiz · 2024-04-09T07:28:15Z

Thanks @Links2004.

Small nits about the commit message (see k8s commit message guidelines:

start title with a capital letter
have properly formatted sentences in the commit message body (start wit ha capital letter, end with a period)
wrap lines (to 72 chars) in the message body

The build-image-cross-generic prow job takes way too much time with this. We need to do something about that 🧐 Either omit armv7 from the test job or try increasing resources of the prow job. @ArangoGutierrez WDYT?

Links2004 · 2024-04-09T07:31:21Z

I can force push a new commit messages if it helps.

ArangoGutierrez · 2024-04-09T08:43:16Z

Thanks @Links2004.

Small nits about the commit message (see k8s commit message guidelines:

start title with a capital letter

have properly formatted sentences in the commit message body (start wit ha capital letter, end with a period)

wrap lines (to 72 chars) in the message body

The build-image-cross-generic prow job takes way too much time with this. We need to do something about that 🧐 Either omit armv7 from the test job or try increasing resources of the prow job. @ArangoGutierrez WDYT?

Umm I agree, we should add some logic to only build armv7 during PostSubmit and not on PreSubmit

ArangoGutierrez · 2024-04-15T13:48:23Z

@Links2004 NFD as a PROW job that runs on each PR, specifically https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-presubmits-generic.yaml#L56 builds images using buildx using the script https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/scripts/test-infra/build-image-cross.sh. we do agree and accept the addition of ARMV7 , what we don't want is to add extra builds during testing time. so please make the needed changes to prevent this and future archs from being built during test time. Extra ARCHes should be for end users to build and manage on their own.

This allows the nfd to run on arm devices like the Raspberry Pi > 2 with armv7 core or armv8 in 32Bit mode. The build tests will only be run for linux/amd64 and linux/arm64. Releases will be made for all Platforms.

Links2004 · 2024-04-15T14:46:38Z

@ArangoGutierrez

I adapted the node-feature-discovery/scripts/test-infra/build-image-cross.sh with the assumtion that this script is only used for the build tests and not for the release process.

ArangoGutierrez · 2024-04-15T15:36:15Z

scripts/test-infra/build-image-cross.sh

@@ -1,4 +1,4 @@
 #!/bin/bash -e

 # cross build
-make image-all
+IMAGE_ALL_PLATFORMS=linux/amd64,linux/arm64 make image-all


@marquiz WDYT

PING @marquiz

Maybe this wouldwork for now. We don't check buildability of armv7 images on every PR. We'd see build failures after the fact. But arch-specific build failures have been super rare so we can probably bear this for now.

marquiz

/lgtm

k8s-ci-robot · 2024-04-25T09:03:08Z

LGTM label has been added.

Git tree hash: 5251194a08da163500a7b082c5b7417e3f3d493a

k8s-ci-robot · 2024-04-25T09:03:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, Links2004, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ArangoGutierrez · 2024-04-25T11:12:22Z

/test pull-node-feature-discovery-build-image-cross-generic

codecov · 2024-04-25T11:30:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.47%. Comparing base (1696c65) to head (8acff5e).
Report is 47 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1659       +/-   ##
===========================================
+ Coverage   30.54%   41.47%   +10.92%     
===========================================
  Files         102       80       -22     
  Lines        9628     7156     -2472     
===========================================
+ Hits         2941     2968       +27     
+ Misses       6416     3903     -2513     
- Partials      271      285       +14

see 33 files with indirect coverage changes

ArangoGutierrez · 2024-04-25T12:00:28Z

/lgtm

…465) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) | minor | `0.15.4` -> `0.16.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/node-feature-discovery (node-feature-discovery)</summary> ### [`v0.16.0`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.0): v0.16 [Compare Source](kubernetes-sigs/node-feature-discovery@v0.15.4...v0.16.0) #### Changelog ##### NodeFeatureGroup API The NodeFeatureGroup custom resource was added to the NFD API. The NodeFeatureGroup API enables the creation of node groups based on features discovered by NFD. The API is an alpha feature and is disabled by default and can be enabled with the NodeFeatureGroupAPI [feature gate](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturegroup). See [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturegroup) for more details. ##### Feature gates NFD adapted the concept of feature gates from Kubernetes to introduce and stabilize new features in a controlled way. See the [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html) for more details. Two existing features ([NodeFeature API](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html#nodefeatureapi) and [disabling label auto-prefixing](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html#disableautoprefix)) were converted into feature gates. ##### Deprecations ##### Upcoming changes Support for [hooks](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/customization-guide.html#hooks) is deprecated since [v0.12.0](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.12.0) and will be completely dropped in the NFD v0.17. ##### RDT feature labels removed The `feature.node.kubernetes.io/cpu-rdt.*` feature labels that were deprecated in NFD [v0.13](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.13.0) were removed. RDT features are still available for use in [NodeFeatureRules](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturerule) for custom labels. ##### Deprecated flags and options The [autoDefaultNs](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/master-configuration-reference.html#autodefaultns) config file option of nfd-master is deprecated and will be removed in NFD v0.17. Superseded by the [DisableAutoPrefix](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html#disableautoprefix) feature gate (`featureGates.DisableAutoPrefix` Helm parameter). The `-enable-nodefeature-api` command line flag of nfd-master and nfd-worker and the corresponding `enableNodeFeatureApi` [Helm chart parameter](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/deployment/helm.html#general-parameters) have been deprecated and will be removed in NFD v0.17. Superseded by the [NodeFeature API](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/reference/feature-gates.html#nodefeatureapi) feature gate (`featureGates.NodeFeatureAPI` Helm parameter). The `-crd-controller` command line flag of nfd-master is deprecated and will be removed with the gRPC API in a future release. ##### Miscellaneous ##### Network devices Discover speed of virtual network interfaces. ##### DMI Added support for detecting DMI attributes from `/sys/devices/virtual/dmi/id/`. In v0.16 only `sys_vendor` discovered, available as `system.dmiid.sys_vendor` feature for use in [NodeFeatureRules](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturerule). ##### Swap Discover the availability of swap on the node. Available as `memory.swap.enabled` feature for use in [NodeFeatureRules](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/custom-resources.html#nodefeaturerule). ##### Helm chart Now all nodes are cleaned up (feature labels, annotations, extended resources and taints are removed) after uninstalling NFD using a post-delete hook. The Helm chart now sets resource requests (cpu and memory) for NFD pods. Users may want to adjust these for their cluster. An option to set the pod priority class was added. See [Helm chart parameters](https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/deployment/helm.html#chart-parameters) in the documentation). ##### Container health A gRPC health server was added to the nfd-master, nfd-worker and nfd-topology-updater daemons. Deployments (Helm and kustomize) configure container liveness and readiness probes to use that for health checking. #### List of PRs - github: update tagging instructions in release checklists ([#1527](kubernetes-sigs/node-feature-discovery#1527)) - Update readme to v0.15.0 release ([#1524](kubernetes-sigs/node-feature-discovery#1524)) - makefile: fix build: target ([#1528](kubernetes-sigs/node-feature-discovery#1528)) - Makefile: add -timeout argument to e2e-tests ([#1526](kubernetes-sigs/node-feature-discovery#1526)) - helm: add post-delete hook that cleans up the node ([#1532](kubernetes-sigs/node-feature-discovery#1532)) - deployment/kustomize: drop the sample cert-manager overlay ([#1534](kubernetes-sigs/node-feature-discovery#1534)) - nfd-master: run a separate gRPC health server ([#1535](kubernetes-sigs/node-feature-discovery#1535)) - source/network: discover speed of virtual network interfaces ([#1536](kubernetes-sigs/node-feature-discovery#1536)) - go.mod: update dependencies ([#1539](kubernetes-sigs/node-feature-discovery#1539)) - chore: combine cpu count and thread_siblings functions into discover topology function ([#1505](kubernetes-sigs/node-feature-discovery#1505)) - source/cpu: drop deprecated cpu-rdt labels ([#1530](kubernetes-sigs/node-feature-discovery#1530)) - Update readme to v0.15.1 release ([#1552](kubernetes-sigs/node-feature-discovery#1552)) - hack/generate: patch auto-generated deepcopy functions ([#1553](kubernetes-sigs/node-feature-discovery#1553)) - apis/nfd: Trivial typo fix in tests ([#1537](kubernetes-sigs/node-feature-discovery#1537)) - docs: update docs build dependencies ([#1543](kubernetes-sigs/node-feature-discovery#1543)) - topology-updater: initialize properly with -no-publish ([#1554](kubernetes-sigs/node-feature-discovery#1554)) - topology-updater: document the -no-publish flag correctly ([#1555](kubernetes-sigs/node-feature-discovery#1555)) - Wrap nested errors ([#1558](kubernetes-sigs/node-feature-discovery#1558)) - Prevent `nfd-worker` erroring when reading attributes from paravirtual devices ([#1557](kubernetes-sigs/node-feature-discovery#1557)) - pkg/utils: move GetKubeconfig from pkg/apihelper here ([#1562](kubernetes-sigs/node-feature-discovery#1562)) - OWNERS: add AhmedGrati as a reviewer ([#1564](kubernetes-sigs/node-feature-discovery#1564)) - deployment/helm: don't deploy topology-updater conf unnecessarily ([#1565](kubernetes-sigs/node-feature-discovery#1565)) - topology-updater: get topology api client directly ([#1566](kubernetes-sigs/node-feature-discovery#1566)) - pkg/utils: move JsonPatch from pkg/apihelper ([#1568](kubernetes-sigs/node-feature-discovery#1568)) - nfd-master: ditch apihelper ([#1570](kubernetes-sigs/node-feature-discovery#1570)) - topology-updater: ditch apihelper ([#1567](kubernetes-sigs/node-feature-discovery#1567)) - Drop pkg/apihelper ([#1561](kubernetes-sigs/node-feature-discovery#1561)) - nfd-master: fix node status patching ([#1571](kubernetes-sigs/node-feature-discovery#1571)) - nfd-topology-updater add pods fingerprint by default ([#1560](kubernetes-sigs/node-feature-discovery#1560)) - docs: add KEP of Spiffe integration ([#1444](kubernetes-sigs/node-feature-discovery#1444)) - docs: document removal of hooks in v0.17 ([#1573](kubernetes-sigs/node-feature-discovery#1573)) - build(deps): bump github.com/opencontainers/runc from 1.1.10 to 1.1.12 ([#1575](kubernetes-sigs/node-feature-discovery#1575)) - build(deps-dev): bump nokogiri from 1.16.0 to 1.16.2 in /docs ([#1576](kubernetes-sigs/node-feature-discovery#1576)) - scripts/test-infra: bump golangci-lint to v1.56.1 ([#1580](kubernetes-sigs/node-feature-discovery#1580)) - scripts/test-infra: bump k8s logcheck to v0.8.1 ([#1583](kubernetes-sigs/node-feature-discovery#1583)) - Bump Go to v1.22 ([#1579](kubernetes-sigs/node-feature-discovery#1579)) - scripts/test-infra: bump helm to v3.14.0 ([#1582](kubernetes-sigs/node-feature-discovery#1582)) - source/kernel: add unit tests for kernel version parsing ([#1588](kubernetes-sigs/node-feature-discovery#1588)) - helm: add priorityClassName option ([#1587](kubernetes-sigs/node-feature-discovery#1587)) - source/pci: add unit test for the pci source ([#1589](kubernetes-sigs/node-feature-discovery#1589)) - nfd-master: log errors on node update retries ([#1591](kubernetes-sigs/node-feature-discovery#1591)) - source/system: Add reading vendor information ([#1574](kubernetes-sigs/node-feature-discovery#1574)) - source/cpu: fix build tags on rdt discovery ([#1594](kubernetes-sigs/node-feature-discovery#1594)) - helm: add ability to use a custom issuer ([#1598](kubernetes-sigs/node-feature-discovery#1598)) - fix hook issue ([#1604](kubernetes-sigs/node-feature-discovery#1604)) - generate: update autogenerate tools ([#1606](kubernetes-sigs/node-feature-discovery#1606)) - apis/nfd/validate: use testify/assert for checking test results ([#1590](kubernetes-sigs/node-feature-discovery#1590)) - Update readme to v0.15.2 release ([#1611](kubernetes-sigs/node-feature-discovery#1611)) - Update generate scripts to use latest code_gen functions ([#1605](kubernetes-sigs/node-feature-discovery#1605)) - nfd-master: mark the -crd-controller flag as deprecated ([#1612](kubernetes-sigs/node-feature-discovery#1612)) - build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 ([#1613](kubernetes-sigs/node-feature-discovery#1613)) - Use close to signal stop channedl in worker and topology-updater ([#1620](kubernetes-sigs/node-feature-discovery#1620)) - nfd-master: fix memory leak in nfd api-controller ([#1615](kubernetes-sigs/node-feature-discovery#1615)) - Update readme to v0.15.3 release ([#1628](kubernetes-sigs/node-feature-discovery#1628)) - Add FeatureGate framework to handle new features ([#1623](kubernetes-sigs/node-feature-discovery#1623)) - replace AhmedGrati account with TessaIO as reviewer ([#1630](kubernetes-sigs/node-feature-discovery#1630)) - add swap support in nfd ([#1585](kubernetes-sigs/node-feature-discovery#1585)) - nfd-master: check if node exists before trying update ([#1595](kubernetes-sigs/node-feature-discovery#1595)) - Remove references to -enable-nodefeature-api flag ([#1632](kubernetes-sigs/node-feature-discovery#1632)) - Add owner reference to NRT object ([#1602](kubernetes-sigs/node-feature-discovery#1602)) - nfd-master: retry node updates indefinitely ([#1596](kubernetes-sigs/node-feature-discovery#1596)) - nfd-worker: Add liveness probe ([#1609](kubernetes-sigs/node-feature-discovery#1609)) - topology-updater: Set APIVersion, Kind in the OwnerReference explicitly ([#1634](kubernetes-sigs/node-feature-discovery#1634)) - helm: fix invalid name of host-swaps volume ([#1635](kubernetes-sigs/node-feature-discovery#1635)) - nfd-master: do nfd API scheme registration in an init function ([#1641](kubernetes-sigs/node-feature-discovery#1641)) - chore/deployment: add resources requests and limits for helm and Kustomize ([#1631](kubernetes-sigs/node-feature-discovery#1631)) - nfd-topology-updater: Add liveness probe ([#1643](kubernetes-sigs/node-feature-discovery#1643)) - nfd-master: get node object only once when updating node ([#1652](kubernetes-sigs/node-feature-discovery#1652)) - chore/deploy: make interval property in PodMonitor configurable ([#1639](kubernetes-sigs/node-feature-discovery#1639)) - nfd-master: protect node updater pool queueing with a lock ([#1642](kubernetes-sigs/node-feature-discovery#1642)) - nfd-master: prevent crash on empty config struct ([#1657](kubernetes-sigs/node-feature-discovery#1657)) - Update readme to v0.15.4 release ([#1650](kubernetes-sigs/node-feature-discovery#1650)) - Tidy up usage of channels for signaling ([#1656](kubernetes-sigs/node-feature-discovery#1656)) - nfd-master: implement opts for modifying NfdMaster instance ([#1658](kubernetes-sigs/node-feature-discovery#1658)) - nfd-master: parse kubeconfig even with NoPublish set ([#1655](kubernetes-sigs/node-feature-discovery#1655)) - Move NFD api to a separate go mod ([#1600](kubernetes-sigs/node-feature-discovery#1600)) - api/nfd: run go mod tidy ([#1661](kubernetes-sigs/node-feature-discovery#1661)) - Fix Make generate ([#1662](kubernetes-sigs/node-feature-discovery#1662)) - apis/nfd/validate: loosen validation of feature annotations ([#1633](kubernetes-sigs/node-feature-discovery#1633)) - nfd-master: use separate k8s api clients for each updater ([#1653](kubernetes-sigs/node-feature-discovery#1653)) - nfd-master: stop node-updater pool before reconfiguring api-controller ([#1660](kubernetes-sigs/node-feature-discovery#1660)) - build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0 ([#1665](kubernetes-sigs/node-feature-discovery#1665)) - chore/nfd-master: remove warnings in nfd-master unit tests file ([#1668](kubernetes-sigs/node-feature-discovery#1668)) - build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0 in api/nfd ([#1666](kubernetes-sigs/node-feature-discovery#1666)) - apis/nfd: add unit tests for match name functions ([#1667](kubernetes-sigs/node-feature-discovery#1667)) - apis/nfd: no error on ops that never match ([#1670](kubernetes-sigs/node-feature-discovery#1670)) - api/nfd: use varargs in the NewInstanceFeatures helper ([#1669](kubernetes-sigs/node-feature-discovery#1669)) - scripts/test-infra: bump golangci-lint to v1.57.2 ([#1674](kubernetes-sigs/node-feature-discovery#1674)) - add ARMv7 support ([#1659](kubernetes-sigs/node-feature-discovery#1659)) - docs: document trade-offs in memory configuration ([#1651](kubernetes-sigs/node-feature-discovery#1651)) - go.mod: bump kubernetes to v1.30 ([#1675](kubernetes-sigs/node-feature-discovery#1675)) - cloudbuild.yaml: change machine type to e1-highcpu-32 ([#1678](kubernetes-sigs/node-feature-discovery#1678)) - test/e2e: stop importing kubernetes test/e2e ([#1680](kubernetes-sigs/node-feature-discovery#1680)) - hack/init-buildx.sh: fix broken patter matching ([#1683](kubernetes-sigs/node-feature-discovery#1683)) - Disable armv7 builds ([#1677](kubernetes-sigs/node-feature-discovery#1677)) - cloudbuild.yaml: downgrade machine type to e2-highcpu-8 ([#1685](kubernetes-sigs/node-feature-discovery#1685)) - Update update_codegen.sh for v0.30 version of codegen tools ([#1681](kubernetes-sigs/node-feature-discovery#1681)) - Dependabot: Add proper dependabot config file ([#1679](kubernetes-sigs/node-feature-discovery#1679)) - build(deps): bump azure/setup-helm from 3 to 4 ([#1686](kubernetes-sigs/node-feature-discovery#1686)) - build(deps): bump actions/checkout from 1 to 4 ([#1687](kubernetes-sigs/node-feature-discovery#1687)) - build(deps): bump golang.org/x/net from 0.23.0 to 0.24.0 ([#1689](kubernetes-sigs/node-feature-discovery#1689)) - build(deps): bump sigs.k8s.io/yaml from 1.3.0 to 1.4.0 ([#1691](kubernetes-sigs/node-feature-discovery#1691)) - build(deps): bump github.com/onsi/gomega from 1.31.0 to 1.33.0 ([#1692](kubernetes-sigs/node-feature-discovery#1692)) - build(deps): bump github.com/onsi/ginkgo/v2 from 2.15.0 to 2.17.2 ([#1690](kubernetes-sigs/node-feature-discovery#1690)) - build(deps): bump github.com/jaypipes/ghw from 0.8.1-0.20210827132705-c7224150a17e to 0.12.0 ([#1688](kubernetes-sigs/node-feature-discovery#1688)) - apis/nfd: increase unit test coverage ([#1693](kubernetes-sigs/node-feature-discovery#1693)) - build: specify buildx builder name everywhere ([#1684](kubernetes-sigs/node-feature-discovery#1684)) - source/kernel: silence misleading error on selinux detection ([#1694](kubernetes-sigs/node-feature-discovery#1694)) - build(deps): bump github.com/klauspost/cpuid/v2 from 2.2.6 to 2.2.7 ([#1695](kubernetes-sigs/node-feature-discovery#1695)) - build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 ([#1696](kubernetes-sigs/node-feature-discovery#1696)) - build(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 ([#1698](kubernetes-sigs/node-feature-discovery#1698)) - build(deps): bump github.com/onsi/gomega from 1.33.0 to 1.33.1 ([#1699](kubernetes-sigs/node-feature-discovery#1699)) - build(deps): bump github.com/k8stopologyawareschedwg/noderesourcetopology-api from 0.1.0 to 0.1.2 ([#1697](kubernetes-sigs/node-feature-discovery#1697)) - build(deps): bump golang.org/x/net from 0.24.0 to 0.25.0 ([#1701](kubernetes-sigs/node-feature-discovery#1701)) - build(deps): bump google.golang.org/grpc from 1.60.1 to 1.63.2 ([#1702](kubernetes-sigs/node-feature-discovery#1702)) - build(deps-dev): bump nokogiri from 1.16.2 to 1.16.5 in /docs ([#1706](kubernetes-sigs/node-feature-discovery#1706)) - build(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.1 ([#1703](kubernetes-sigs/node-feature-discovery#1703)) - build(deps): bump github.com/k8stopologyawareschedwg/podfingerprint from 0.1.2 to 0.2.2 ([#1705](kubernetes-sigs/node-feature-discovery#1705)) - nfd-master: add DisableAutoPrefix feature gate ([#1707](kubernetes-sigs/node-feature-discovery#1707)) - Re-add -enable-nodefeature-api cmdline flag ([#1708](kubernetes-sigs/node-feature-discovery#1708)) - build(deps): bump rexml from 3.2.6 to 3.2.8 in /docs ([#1709](kubernetes-sigs/node-feature-discovery#1709)) - build(deps): bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3 ([#1711](kubernetes-sigs/node-feature-discovery#1711)) - Add NodeFeatureGroup API ([#1487](kubernetes-sigs/node-feature-discovery#1487)) - api/nfd: document all undocumented fields in the types ([#1714](kubernetes-sigs/node-feature-discovery#1714)) - nfd-worker: improved log when creating NodeFeature object ([#1713](kubernetes-sigs/node-feature-discovery#1713)) - apis/nfd: allow different types of features of the same name ([#1671](kubernetes-sigs/node-feature-discovery#1671)) - cpu: advertise AVX10 version ([#1673](kubernetes-sigs/node-feature-discovery#1673)) - source/cpu: disable AVX10 label ([#1715](kubernetes-sigs/node-feature-discovery#1715)) - docs/helm: document all feature gates ([#1716](kubernetes-sigs/node-feature-discovery#1716)) - build(deps): bump github.com/onsi/ginkgo/v2 from 2.17.3 to 2.19.0 ([#1717](kubernetes-sigs/node-feature-discovery#1717)) - docs: add more cross-references to NodeFeatureGroup API ([#1718](kubernetes-sigs/node-feature-discovery#1718)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/465 Co-authored-by: Renovate <renovate@ptinem.casa> Co-committed-by: Renovate <renovate@ptinem.casa>

k8s-ci-robot requested review from kad and zvonkok April 6, 2024 09:03

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 6, 2024

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2024

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 6, 2024

Links2004 changed the title ~~add armv7 support~~ add ARMv7 support Apr 6, 2024

ArangoGutierrez requested changes Apr 8, 2024

View reviewed changes

Links2004 requested a review from ArangoGutierrez April 8, 2024 11:10

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2024

ArangoGutierrez approved these changes Apr 8, 2024

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024

Add armv7 support

8acff5e

This allows the nfd to run on arm devices like the Raspberry Pi > 2 with armv7 core or armv8 in 32Bit mode. The build tests will only be run for linux/amd64 and linux/arm64. Releases will be made for all Platforms.

Links2004 force-pushed the arm-support branch from 31146cd to 8acff5e Compare April 15, 2024 14:46

ArangoGutierrez reviewed Apr 15, 2024

View reviewed changes

marquiz approved these changes Apr 25, 2024

View reviewed changes

k8s-ci-robot assigned marquiz Apr 25, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024

k8s-ci-robot assigned ArangoGutierrez Apr 25, 2024

k8s-ci-robot merged commit 688e3ce into kubernetes-sigs:master Apr 25, 2024
12 checks passed

marquiz mentioned this pull request May 24, 2024

Release v0.16 #1572

Closed

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add ARMv7 support #1659

add ARMv7 support #1659

Links2004 commented Apr 6, 2024 •

edited

Loading

linux-foundation-easycla bot commented Apr 6, 2024 •

edited

Loading

k8s-ci-robot commented Apr 6, 2024

k8s-ci-robot commented Apr 6, 2024

netlify bot commented Apr 6, 2024 •

edited

Loading

Links2004 commented Apr 6, 2024

ArangoGutierrez Apr 8, 2024 •

edited

Loading

Links2004 Apr 8, 2024

ArangoGutierrez commented Apr 8, 2024

ArangoGutierrez left a comment

marquiz commented Apr 9, 2024

Links2004 commented Apr 9, 2024

ArangoGutierrez commented Apr 9, 2024

ArangoGutierrez commented Apr 15, 2024

Links2004 commented Apr 15, 2024

ArangoGutierrez Apr 15, 2024

ArangoGutierrez Apr 24, 2024

marquiz Apr 25, 2024

marquiz left a comment

k8s-ci-robot commented Apr 25, 2024

k8s-ci-robot commented Apr 25, 2024

ArangoGutierrez commented Apr 25, 2024

codecov bot commented Apr 25, 2024

ArangoGutierrez commented Apr 25, 2024

	IMAGE_ALL_PLATFORMS ?= linux/amd64,linux/arm64,linux/arm/v7
	IMAGE_ALL_PLATFORMS ?= linux/amd64,linux/arm64,linux/arm32v7

add ARMv7 support #1659

add ARMv7 support #1659

Conversation

Links2004 commented Apr 6, 2024 • edited Loading

linux-foundation-easycla bot commented Apr 6, 2024 • edited Loading

k8s-ci-robot commented Apr 6, 2024

k8s-ci-robot commented Apr 6, 2024

netlify bot commented Apr 6, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Links2004 commented Apr 6, 2024

ArangoGutierrez Apr 8, 2024 • edited Loading

Choose a reason for hiding this comment

Links2004 Apr 8, 2024

Choose a reason for hiding this comment

ArangoGutierrez commented Apr 8, 2024

ArangoGutierrez left a comment

Choose a reason for hiding this comment

marquiz commented Apr 9, 2024

Links2004 commented Apr 9, 2024

ArangoGutierrez commented Apr 9, 2024

ArangoGutierrez commented Apr 15, 2024

Links2004 commented Apr 15, 2024

ArangoGutierrez Apr 15, 2024

Choose a reason for hiding this comment

ArangoGutierrez Apr 24, 2024

Choose a reason for hiding this comment

marquiz Apr 25, 2024

Choose a reason for hiding this comment

marquiz left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 25, 2024

k8s-ci-robot commented Apr 25, 2024

ArangoGutierrez commented Apr 25, 2024

codecov bot commented Apr 25, 2024

Codecov Report

ArangoGutierrez commented Apr 25, 2024

Links2004 commented Apr 6, 2024 •

edited

Loading

linux-foundation-easycla bot commented Apr 6, 2024 •

edited

Loading

netlify bot commented Apr 6, 2024 •

edited

Loading

ArangoGutierrez Apr 8, 2024 •

edited

Loading