Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis/nfd/validate: loosen validation of feature annotations #1633

Merged
merged 2 commits into from
Apr 11, 2024

Commits on Apr 9, 2024

  1. apis/nfd/validate: loosen validation of feature annotations

    Don't require that the annotation value must conform to the (strict)
    requirements of label values. In the Kubernetes API annotation values do
    not have other restrictions than that the total size (keys and values)
    of _all_ annotations combined of an object must not exceed 256kB.
    
    This patch sets a maximum size limit of 1kB for the value of a single
    feature annotation created by NFD. This limit is rather arbitrary but
    should be enough for the NFD usage scenarios (until proven wrong).
    marquiz committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a9167e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. apis/nfd/validate: more comprehensive unit tests

    Also add license header to the test.go file and fix one bug in
    MatchFeature validation.
    marquiz committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7fbada8 View commit details
    Browse the repository at this point in the history