topology-updater: NRT CRD resourses are not cleaned up, on node deletion(scale-in)

[nmathew]

Node Resource Topology node specific CRD resources are not cleaned up on node deletion(scale-in).
I think this should be part of nfd worker/updater.

[nmathew]

@fromanirh

[ffromani]

yes, this is a gap. Besides littering the cluster, there is any other impact?

[nmathew]

No functional impact...

[marquiz]

NFD-Master could have a garbage-collection loop to delete NRT objects for non-existing nodes
/help

[k8s-ci-robot]

@marquiz:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

NFD-Master could have a garbage-collection loop to delete NRT objects for non-existing nodes
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[PiotrProkop]

I have created PR to address this issue: #1024