Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Events #299

Merged
merged 10 commits into from
Jan 4, 2025
Merged

Add Events #299

merged 10 commits into from
Jan 4, 2025

Conversation

Edwinhr716
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it

Adds more events

Which issue(s) this PR fixes

Fixes #243

Special notes for your reviewer

Does this PR introduce a user-facing change?

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g January 3, 2025 20:01
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jan 3, 2025

Can you show example events to see how they look like in practice?

@Edwinhr716
Copy link
Contributor Author

Sure

Events:
  Type    Reason                Age                    From             Message
  ----    ------                ----                   ----             -------
  Normal  GroupsAreProgressing  3m22s                  pod              creating worker sts for leader pod lws-4
  Normal  GroupsAreProgressing  3m22s                  pod              creating worker sts for leader pod lws-1
  Normal  GroupsAreProgressing  3m22s                  leaderworkerset  Creating leader sts lws
  Normal  GroupsAreProgressing  3m22s                  pod              creating worker sts for leader pod lws-3
  Normal  GroupsAreProgressing  3m22s                  leaderworkerset  Replicas are progressing, with 0 groups ready of total 10 groups
  Normal  GroupsAreProgressing  2m19s (x2 over 2m19s)  leaderworkerset  Replicas are progressing, with 9 groups ready of total 10 groups
  Normal  RecreatePodGroup      2m16s (x3 over 2m20s)  pod              deleting lws-0 pod to recreate group 0
  Normal  GroupsAreProgressing  2m14s (x4 over 3m22s)  pod              creating worker sts for leader pod lws-0
  Normal  GroupsAreUpgrading    36s                    leaderworkerset  changing partition from 10, to 9
  Normal  GroupsAreUpgrading    36s (x2 over 36s)      leaderworkerset  Rolling Upgrade is in progress, with 10 groups ready of total 10 groups
  Normal  GroupsAreUpgrading    34s                    leaderworkerset  changing partition from 9, to 8
  Normal  GroupsAreProgressing  33s                    pod              creating worker sts for leader pod lws-9
  Normal  GroupsAreUpgrading    32s                    leaderworkerset  changing partition from 8, to 7
  Normal  GroupsAreProgressing  31s (x2 over 3m22s)    pod              creating worker sts for leader pod lws-8
  Normal  GroupsAreUpgrading    29s                    leaderworkerset  changing partition from 7, to 6
  Normal  GroupsAreProgressing  28s (x2 over 3m22s)    pod              creating worker sts for leader pod lws-7
  Normal  GroupsAreUpgrading    26s                    leaderworkerset  changing partition from 6, to 5
  Normal  GroupsAreProgressing  25s (x2 over 3m22s)    pod              creating worker sts for leader pod lws-6
  Normal  GroupsAreUpgrading    23s                    leaderworkerset  changing partition from 5, to 4
  Normal  GroupsAreProgressing  22s (x2 over 3m22s)    pod              creating worker sts for leader pod lws-5
  Normal  GroupsAreUpgrading    20s                    leaderworkerset  changing partition from 4, to 3
  Normal  GroupsAreUpgrading    18s                    leaderworkerset  changing partition from 3, to 2
  Normal  GroupsAreProgressing  17s (x4 over 3m22s)    pod              (combined from similar events): creating worker sts for leader pod lws-3
  Normal  GroupsAreProgressing  14s (x2 over 3m22s)    pod              creating worker sts for leader pod lws-2
  Normal  GroupsAreUpgrading    10s (x3 over 15s)      leaderworkerset  (combined from similar events): deleting maxSurge lws-10 replica
  Normal  AllGroupsReady        7s (x4 over 3m20s)     leaderworkerset  All replicas are ready, with 10 groups ready of total 10 groups

ahg-g
ahg-g reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we be able to add checks on those events to existing integration tests?

cmd/main.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/pod_controller.go Outdated Show resolved Hide resolved
@ahg-g
Copy link
Contributor

ahg-g commented Jan 3, 2025

Can we also start all the messages with a capital letter please.

ahg-g
ahg-g reviewed Jan 4, 2025
View reviewed changes
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a few more suggestions

pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/pod_controller.go Outdated Show resolved Hide resolved
pkg/controllers/pod_controller.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2025
ahg-g
ahg-g reviewed Jan 4, 2025
View reviewed changes
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/pod_controller.go Outdated Show resolved Hide resolved
pkg/controllers/pod_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
pkg/controllers/pod_controller.go Outdated Show resolved Hide resolved
pkg/controllers/leaderworkerset_controller.go Outdated Show resolved Hide resolved
@ahg-g ahg-g added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 4, 2025
@Edwinhr716
Copy link
Contributor Author

/retest

@ahg-g
Copy link
Contributor

ahg-g commented Jan 4, 2025

/retest

Please always make sure to address flaky tests, in this case it is the test itself that needs fixing, but in other cases it could be a bug.

@ahg-g
Copy link
Contributor

ahg-g commented Jan 4, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, Edwinhr716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7c7cbee into kubernetes-sigs:main Jan 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better events for leader pod deletions
3 participants
@Edwinhr716 @ahg-g @k8s-ci-robot