Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Controller Revision #297

Merged
merged 9 commits into from
Jan 3, 2025
Merged

Tests for Controller Revision #297

merged 9 commits into from
Jan 3, 2025

Conversation

Edwinhr716
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it

Adds tests for Controller Revision

Which issue(s) this PR fixes

Fixes #294

Special notes for your reviewer

Does this PR introduce a user-facing change?

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 30, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g December 30, 2024 23:05
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2024
@Edwinhr716
Copy link
Contributor Author

Added integration tests that were previously e2e tests.
Added unit tests for revision_util functions
Still to add:

  • Check for amount of revisions in history before, during, and after update
  • e2e test that tries to replicate updating from a previous LWS version

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 30, 2024
ahg-g
ahg-g reviewed Dec 31, 2024
View reviewed changes
pkg/utils/revision/revision_utils.go Outdated Show resolved Hide resolved
pkg/utils/revision/revision_utils_test.go Show resolved Hide resolved
test/testutils/validators.go Outdated Show resolved Hide resolved
test/testutils/util.go Outdated Show resolved Hide resolved
test/testutils/util.go Outdated Show resolved Hide resolved
test/testutils/util.go Outdated Show resolved Hide resolved
test/testutils/util.go Outdated Show resolved Hide resolved
test/testutils/validators.go Show resolved Hide resolved
test/integration/controllers/leaderworkerset_test.go Outdated Show resolved Hide resolved
test/integration/controllers/leaderworkerset_test.go Show resolved Hide resolved
ahg-g
ahg-g reviewed Jan 2, 2025
View reviewed changes
pkg/utils/revision/revision_utils_test.go Show resolved Hide resolved
test/integration/controllers/leaderworkerset_test.go Show resolved Hide resolved
test/testutils/util.go Outdated Show resolved Hide resolved
test/testutils/util.go Show resolved Hide resolved
test/testutils/util.go Outdated Show resolved Hide resolved
@Edwinhr716 Edwinhr716 changed the title [WIP] Tests for Controller Revision Tests for Controller Revision Jan 3, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2025
ahg-g
ahg-g reviewed Jan 3, 2025
View reviewed changes
test/integration/controllers/leaderworkerset_test.go Outdated Show resolved Hide resolved
test/testutils/util.go Outdated Show resolved Hide resolved
test/integration/controllers/leaderworkerset_test.go Show resolved Hide resolved
@ahg-g ahg-g added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 3, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jan 3, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, Edwinhr716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7a3cd29 into kubernetes-sigs:main Jan 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration tests for the controller revision enhancement
3 participants
@Edwinhr716 @ahg-g @k8s-ci-robot