Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat create fake node #499

Closed
wants to merge 1 commit into from

Conversation

huiwq1990
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

For fast create large scale fake nodes.

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huiwq1990
Once this PR has been reviewed and has the lgtm label, please assign yibozhuang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2023
@netlify
Copy link

netlify bot commented Apr 15, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit f5f801b
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/643a0493f1899f00087e702a

@k8s-ci-robot
Copy link
Contributor

Welcome @huiwq1990!

It looks like this is your first PR to kubernetes-sigs/kwok 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kwok has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @huiwq1990. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2023
Signed-off-by: huiwq1990 <huiwq1990@163.com>
@wzshiming
Copy link
Member

wzshiming commented Apr 15, 2023

Thank you for the PR, this feature is already at the 0.3 milestone #413, we want to have a common APIs to configure this without hard coding, if you are interested you can participate in the design of the APIs or even the implementation.😄

@wzshiming
Copy link
Member

wzshiming commented Jul 11, 2023

This feature is designed in #668 and implemented in #707. thank you for all the work you've put into this.
/close

@k8s-ci-robot
Copy link
Contributor

@wzshiming: Closed this PR.

In response to this:

This feature is designed in #668 and implemented in #707.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants