-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a plugin compiler. #957
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9bf4022
to
c0619cd
Compare
@monopole Is this compiler only intended to use in testing? |
c0619cd
to
8478ca6
Compare
For now, yes, But it needs its own test. |
9fe2b3d
to
d430484
Compare
fixed some comments. the goal here is not to make a compiler, but to isolate somewhat complex test infrastructure code that has a particular purpose into a package more appropriate than pkg/target, and place it under test. but it's not used in any commands yet. |
32d36bb
to
d66e482
Compare
d66e482
to
175c754
Compare
/lgtm |
This will better isolate changes from tests as we switch over to modules to better control plugin compatibility assurances. Also, makes it easier to make a
compile
command.