Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a plugin compiler. #957

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

monopole
Copy link
Contributor

@monopole monopole commented Apr 8, 2019

This will better isolate changes from tests as we switch over to modules to better control plugin compatibility assurances. Also, makes it easier to make a compile command.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2019
@monopole monopole removed the request for review from pwittrock April 8, 2019 17:25
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2019
@monopole monopole force-pushed the justTheFactsMaam branch 4 times, most recently from 9bf4022 to c0619cd Compare April 8, 2019 18:20
@Liujingfang1
Copy link
Contributor

@monopole Is this compiler only intended to use in testing?

@monopole
Copy link
Contributor Author

monopole commented Apr 8, 2019

For now, yes, But it needs its own test.
I think we'll need plugin commands like kustomize plugin compile/audit/etc so will use it there too.

@monopole monopole force-pushed the justTheFactsMaam branch 3 times, most recently from 9fe2b3d to d430484 Compare April 8, 2019 22:01
@monopole
Copy link
Contributor Author

monopole commented Apr 8, 2019

fixed some comments.

the goal here is not to make a compiler, but to isolate somewhat complex test infrastructure code that has a particular purpose into a package more appropriate than pkg/target, and place it under test.

but it's not used in any commands yet.

@monopole monopole force-pushed the justTheFactsMaam branch 5 times, most recently from 32d36bb to d66e482 Compare April 9, 2019 00:59
@Liujingfang1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit ee68a9c into kubernetes-sigs:master Apr 9, 2019
@monopole monopole deleted the justTheFactsMaam branch April 12, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants