Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for transformer goplugins #946

Merged
merged 2 commits into from
Apr 5, 2019

Conversation

Liujingfang1
Copy link
Contributor

  1. Load the file content from paths listed under transformers as resources.
  2. Read the Kind from the resource and treat it as the goplugin name
  3. The goplugin is searched under $XDG_CONFIG_HOME/kustomize/plugins, if $XDG_CONFIG_HOME is not defined, search $HOME/.config/kustomize/plugins
  4. The goplugin is configued (you can also think of this as input arguments to a program) by the resource loaded in step 1.
  5. Also need to run kustomize build -enable_alpha_goplugins_accept_panic_risk to allow goplugins

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2019
@Liujingfang1 Liujingfang1 requested a review from monopole April 5, 2019 00:03
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2019
@k8s-ci-robot k8s-ci-robot requested a review from pwittrock April 5, 2019 00:03
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 5, 2019
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9e8d06e into kubernetes-sigs:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants