Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove starlark support #5768

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

dims
Copy link
Member

@dims dims commented Sep 23, 2024

Helps drop starlark from kubernetes dependencies, also found an issue here #4349 as well

❯ go mod graph | grep go.starlark.net | sort
go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca github.com/chzyer/logex@v1.1.10
go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca github.com/chzyer/readline@v0.0.0-20180603132655-2972be24d48e
go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca github.com/chzyer/test@v0.0.0-20180213035817-a1ea475d72b1
go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca github.com/google/go-cmp@v0.5.1
go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca golang.org/x/sys@v0.0.0-20220715151400-c0bba94af5f8
go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca golang.org/x/term@v0.0.0-20220526004731-065cf7ba2467
go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca golang.org/x/xerrors@v0.0.0-20200804184101-5ec99f83aff1
go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca google.golang.org/protobuf@v1.25.0
k8s.io/cli-runtime go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca
k8s.io/cli-runtime@v0.0.0 go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca
k8s.io/kubectl go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca
k8s.io/kubectl@v0.0.0 go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca
k8s.io/kubernetes go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca
k8s.io/sample-cli-plugin go.starlark.net@v0.0.0-20230525235612-a134d8f9ddca
sigs.k8s.io/kustomize/api@v0.17.2 go.starlark.net@v0.0.0-20200306205701-8dd3e2ee1dd5
sigs.k8s.io/kustomize/kustomize/v5@v5.4.2 go.starlark.net@v0.0.0-20200306205701-8dd3e2ee1dd5
sigs.k8s.io/kustomize/kyaml@v0.17.1 go.starlark.net@v0.0.0-20200306205701-8dd3e2ee1dd5

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 23, 2024
@dims
Copy link
Member Author

dims commented Sep 24, 2024

/assign @koba1t

Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2024
@koba1t
Copy link
Member

koba1t commented Sep 25, 2024

@dims
Thanks for sending the cleanup PR for the deprecated feature!

However, I think it would be better to remove the three currently deprecated alpha plugins at the same time.
Unless you have a reason to rush the removal of this feature, it may take some time to make progress.
https://kubectl.docs.kubernetes.io/guides/extending_kustomize/#plugin-feature-status

@koba1t
Copy link
Member

koba1t commented Sep 25, 2024

The results of my investigation

According to the Kustomize plugin proposal, we can only remove the legacy 'exec' and 'Go' plugins after we move to the beta phase.
Therefore, we can't delete the above two legacy plugins now.
https://github.com/kubernetes/enhancements/blob/61b21e5105e5fda4d6c53821ff82dd39a1a98f07/keps/sig-cli/2953-kustomize-plugin-graduation/README.md#L587

The proposal says that the 'starlark plugin' will be removed after the transition to beta. However, considering the lack of response to the following issue, we think it is safe to remove it now to cleanup dependencies。
#4349

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2cd9a2e into kubernetes-sigs:master Sep 25, 2024
10 checks passed
@koba1t koba1t mentioned this pull request Sep 25, 2024
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Oct 17, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.4.3` -> `v5.5.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary>

### [`v5.5.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.5.0)

[Compare Source](kubernetes-sigs/kustomize@kustomize/v5.4.3...kustomize/v5.5.0)

### Breaking change

A starlark support for krm functions was removed to cleanup dependencies. kubernetes-sigs/kustomize#5768
This feature was deprecated 3 years ago and removed because there was no desire to continue using it.
kubernetes-sigs/kustomize#5768 (comment)

#### Feature

[#&#8203;5751](kubernetes-sigs/kustomize#5751): Add `--helm-debug` Flag to Kustomize for Enhanced Helm Debugging

#### Fix Bugs

[#&#8203;5458](kubernetes-sigs/kustomize#5458): Sort built-in Namespace kind before CRDs with the same name
[#&#8203;5745](kubernetes-sigs/kustomize#5745): Add Annotation to Control Inline List Conversion in Kustomize Resources"

#### Dependencies

[#&#8203;5763](kubernetes-sigs/kustomize#5763): Update go 1.22.7
[#&#8203;5781](kubernetes-sigs/kustomize#5781): Update kyaml to v0.18.1
[#&#8203;5782](kubernetes-sigs/kustomize#5782): Update cmd/config to v0.15.0
[#&#8203;5783](kubernetes-sigs/kustomize#5783): Update api to v0.18.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants