Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test api in workflows #3999

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Test api in workflows #3999

merged 1 commit into from
Jun 16, 2021

Conversation

campoy
Copy link
Contributor

@campoy campoy commented Jun 16, 2021 •
edited
Loading

During development of #3997 we noticed api was not being tested in other platforms.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @campoy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2021
@natasha41575
Copy link
Contributor

/ok-to-test

It's really weird that these tests fail in the Go workflows, but not in kustomize-presubmit-master

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
@natasha41575
Copy link
Contributor

natasha41575 commented Jun 16, 2021 •
edited
Loading

Would you mind fixing the failing tests as part of this PR? If it's too difficult we can file an issue and dig into it separately at a later time.

@campoy
Copy link
Contributor Author

campoy commented Jun 16, 2021

It is actually quite a change, since the current abstraction doesn't handle the different separator between windows and the rest. I'd rather make that into a different PR.

@k8s-ci-robot
Copy link
Contributor

@campoy: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@natasha41575
Copy link
Contributor

natasha41575 commented Jun 16, 2021 •
edited
Loading

Let's skip the windows tests by adding a similar // +build !windows comment to the failing test files

campoy
campoy commented Jun 16, 2021
View reviewed changes
.github/workflows/go.yml
@@ -93,6 +101,11 @@ jobs:
run: go test -cover ./...
working-directory: ./kyaml

# TODO: uncomment once Windows tests are passing.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue should be created to fix these tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed #4001

@natasha41575
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: campoy, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit ef1b9d4 into kubernetes-sigs:master Jun 16, 2021
@campoy campoy deleted the patch-1 branch June 16, 2021 21:36
@campoy campoy mentioned this pull request Apr 11, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@monopole monopole Awaiting requested review from monopole

@Shell32-Natsu Shell32-Natsu Awaiting requested review from Shell32-Natsu

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@campoy @k8s-ci-robot @natasha41575