add generated annotation

[pnovotnak]

closes #353

Add a common label to generated objects, so that they may be identified as such. I don't think this requires documentation--the first place someone will probably look for this information on generated objects themselves.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pnovotnak]

I just signed the CLA (again?) And I've already signed on behalf of my company so I think I'm good now?

[pnovotnak]

/check-cla

[pnovotnak]

Looks like this PR is a little premature, I'll wrap it up tomorrow

[monopole]

/lgtm

[monopole]

/hold

test needs fixing.

Also, how about adding a new field to the kustomization.yaml file to allow people to add the annotation optionally rather than hardcoding it.

[pnovotnak]

@monopole I thought about that--I think it might be a good idea to add both, allowing users to overwrite the value of the default. Sound Ok?

[pnovotnak]

Ah wait, @monopole, we can do this already with *Generator[*].behavior: merge

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pnovotnak
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: monopole

If they are not already assigned, you can assign the PR to them by writing /assign @monopole in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pnovotnak]

Ok, tests are fixed, and I added a testcase for both configmaps and secrets that are not generated (neither should have the generated annotation applied).

I think this is ready to go if someone has time to review

[monopole]

Hi, sorry about the delay.

We think this is a good feature, but would prefer to make it strictly optional.

@Liujingfang1 and i talked, and think it would be good to add a field at the root level - i.e.
here: https://github.com/kubernetes-sigs/kustomize/blob/master/pkg/types/kustomization.go#L27

called, say. GeneratorOptions that would, inside it, have options to modify the behavior of all secret and configmap generators (e.g. add a common annotation to them). This way we have a means to grow and add new options later.

E.g.

type Kustomization struct {
  ...
 GeneratorOptions GeneratorOptions
 ...
}
type GeneratorOptions struct {
 Labels map[string]string
 Annotations map[string]string
}

This PR would get smaller, because there'd be no need to change the data for all the tests. Just add new tests.

[Liujingfang1]

@pnovotnak What's the progress on this? Do you need any help?

[pnovotnak]

@Liujingfang1 Sorry! I hadn't been keeping up with my GH notifications. I'll make the change today

[Liujingfang1]

I added generatorOptions in kustomization type. It can add optional labels/annotations to generated resources. #494