Skip to content

Commit

Permalink
Implement code reviews for Update Namespace and Name simultaneously
Browse files Browse the repository at this point in the history
  • Loading branch information
jbrette committed Jul 23, 2019
1 parent 2e46bc8 commit 245673b
Showing 1 changed file with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,15 @@ metadata:
name: crd
`)

// Import note: The namespace transformer is in charge of
// the metadata.namespace field. The namespace transformer SHOULD
// NOT modify neither the "namespace" subfield within the
// ClusterRoleBinding.subjects field nor the "namespace"
// subfield in the ValidatingWebhookConfiguration.webhooks field.
// This is the role of the namereference Transformer to handle
// object reference changes (prefix/suffix and namespace).
// For use cases involving simultaneous change of name and namespace,
// refer to namespaces tests in pkg/target test suites.
th.AssertActualEqualsExpected(rm, `
apiVersion: v1
kind: ConfigMap
Expand Down

0 comments on commit 245673b

Please sign in to comment.