Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alculquicondor from OWNERS #3296

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

alculquicondor
Copy link
Contributor

@alculquicondor alculquicondor commented Oct 23, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

I'm super proud of what we have achieved with this project that started almost 3 years ago.
We not only built important features for real users, but we did so with care and passion for writing good software.
And it paid off. Kueue is an important building block for large and small companies doing AI training on Kubernetes.

I am confident that @tenzen-y and @mimowo can lead the project to higher levels. And we are already seeing multiple other contributors stepping up with designs, code and ideas.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/hold

I can still help around until Friday, but I wanted to have the PR ready to go :)

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 889e6a3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67191b00bfb6c000087e3911

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2024
Change-Id: I92674409fa3e6e72b318883f6fe963211f8011c9
@mbobrovskyi
Copy link
Contributor

@alculquicondor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Even the tests are not happy about it.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not imagine the success of this project without you.
Let me commend you for your unwavering improvement of this project so far.
You have contributed not only to software development but to the growing community as well.

I am proud to have been working with you on this project. We are still part of SIG scheduling, so we hope to collaborate with scheduling fields in the future.
Congrats on your next journey!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6c0480a90455e4c2c5598be9859cf31223a36fd3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alculquicondor,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

/retest

@mimowo
Copy link
Contributor

mimowo commented Oct 24, 2024

Aldo, congrats for driving the successful project from the ground up. You've not only led the project but also the whole community around it, on issues, on PRs, on slack and more.

Good luck on your next endeavours, and always feel free to return, send a PR or chime into discussions :).

@alculquicondor
Copy link
Contributor Author

/hold cancel

Thank you all 😭

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2024
@tenzen-y
Copy link
Member

/hold cancel

Thank you all 😭

😭😭😭

1 similar comment
@mbobrovskyi
Copy link
Contributor

/hold cancel

Thank you all 😭

😭😭😭

@k8s-ci-robot k8s-ci-robot merged commit 3d278a9 into kubernetes-sigs:main Oct 25, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Oct 25, 2024
@alculquicondor
Copy link
Contributor Author

/cherry-pick website

@k8s-infra-cherrypick-robot
Copy link
Contributor

@alculquicondor: #3296 failed to apply on top of branch "website":

Applying: Remove alculquicondor from OWNERS
Using index info to reconstruct a base tree...
M	.github/ISSUE_TEMPLATE/NEW_RELEASE.md
Falling back to patching base and 3-way merge...
Auto-merging .github/ISSUE_TEMPLATE/NEW_RELEASE.md
CONFLICT (content): Merge conflict in .github/ISSUE_TEMPLATE/NEW_RELEASE.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Remove alculquicondor from OWNERS

In response to this:

/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

PBundyra pushed a commit to PBundyra/kueue that referenced this pull request Nov 5, 2024
Change-Id: I92674409fa3e6e72b318883f6fe963211f8011c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants