Remove kubernetes 1.27 from supported versions #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/S
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/assign |
mbobrovskyi
reviewed
Oct 17, 2024
vladikkuzn
force-pushed
the
remove-1.27
branch
from
bf855bc
to
7f999cf
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vladikkuzn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
vladikkuzn
changed the title
k8s-ci-robot
added
release-note
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
vladikkuzn
force-pushed
the
remove-1.27
branch
from
7f999cf
to
ae8dfdf
Compare
vladikkuzn
force-pushed
the
remove-1.27
branch
from
ae8dfdf
to
ff9a34f
Compare
k8s-ci-robot
added
size/L
mbobrovskyi
reviewed
Oct 18, 2024
| if v.String() == "" || v.LessThan(kubeversion.KubeVersion1_27) { | ||
| return false, fmt.Errorf("kubernetesVersion %q: %w", v.String(), errPodNoSupportKubeVersion) | ||
| } | ||
| func CanSupportIntegration(_ ...jobframework.Option) (bool, error) { |
There was a problem hiding this comment.
Can we remove this function as well? It seems to be optional.
|
As we discussed here we should merge this after Kueue 0.9 release is finalized. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removes skip of tests which are not supported on k8s with version less then 1.27, since we are running tests on 1.28+
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Done per discussion here: #3001 (comment)
Does this PR introduce a user-facing change?