Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Implementation for Topology Aware Scheduling [prototype for testing e2e, DO NOT MERGE] #3218

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: Implementation for Topology Aware Scheduling [prototype for testing e2e, DO NOT MERGE] #3218

wants to merge 3 commits into from

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 14, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #2724

Special notes for your reviewer:

This is an e2e prototype of the feature. I used it to evaluate if there are no gaps in the KEP. There are no bigger gaps, but doing the prototype I identified a couple of issues that could be improved in the design. I will submit a KEP update PR.

Comments are welcome, but the actual code to merge will be in separate smaller PRs.

Things which are still missing in the PR:

  • validation (hard and soft)
  • sending events from the TASResourceFlavorController or TASTopologyUngater
  • skipping Failed pods in TASTopologyUngater (DONE)
  • use the expectations mechanism in TASTopologyUngater (DONE)
  • add higher-level test (integration / e2e) for JobSet
  • tracking usage from DaemonSet pods

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@mimowo mimowo changed the title Implementation for Topology Aware Scheduling Implementation for Topology Aware Scheduling (e2e prototype) Oct 14, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Oct 14, 2024

/test all

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 14, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit c406194
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/671739c57fe5da000886786c

@mimowo
Copy link
Contributor Author

mimowo commented Oct 14, 2024

cc @PBundyra please check the "Special notes for your reviewer".

@mimowo mimowo force-pushed the tas-proto branch 2 times, most recently from e51c920 to b187bdf Compare October 14, 2024 10:54
@mimowo
Copy link
Contributor Author

mimowo commented Oct 14, 2024

/test all

@mimowo
Copy link
Contributor Author

mimowo commented Oct 14, 2024

/test all

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2024
@mimowo mimowo mentioned this pull request Oct 15, 2024
Merged
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2024
@mimowo mimowo changed the title Implementation for Topology Aware Scheduling (e2e prototype) WIP: Implementation for Topology Aware Scheduling [prototype for testing e2e, DO NOT MERGE] Oct 15, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Oct 15, 2024

/test all

@mimowo mimowo force-pushed the tas-proto branch 2 times, most recently from eff20d6 to 1706fba Compare October 15, 2024 11:15
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2024
@mimowo mimowo force-pushed the tas-proto branch 2 times, most recently from f20e847 to b3c1968 Compare October 18, 2024 15:31
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Oct 21, 2024

/test all

@mimowo
Copy link
Contributor Author

mimowo commented Oct 21, 2024

/test all

@mimowo
Copy link
Contributor Author

mimowo commented Oct 21, 2024

/test all

@mimowo mimowo force-pushed the tas-proto branch 3 times, most recently from 38264dd to c7aea4c Compare October 21, 2024 14:19
@mimowo
Copy link
Contributor Author

mimowo commented Oct 21, 2024

/test all

@mimowo
Copy link
Contributor Author

mimowo commented Oct 21, 2024

/test all

@mimowo
Copy link
Contributor Author

mimowo commented Oct 21, 2024

/test all

@mimowo mimowo closed this Oct 21, 2024
@mimowo mimowo reopened this Oct 21, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Oct 21, 2024

/test all

@mimowo mimowo mentioned this pull request Oct 21, 2024
Merged
@mimowo
Copy link
Contributor Author

mimowo commented Oct 22, 2024

/test all

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

@trasc trasc Awaiting requested review from trasc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mimowo @k8s-ci-robot