[batch/job] Allow unsuspending a job with a parallelism equal or less then minimum.

[trasc]

What type of PR is this?

/kind bug

What this PR does / why we need it:

[batch/job] Allow unsuspending a job with a parallelism equal or less then min.

The minimum can be reached in the usual partial admission operation. Values less then minimum can be reached in case of readmitting jobs which have marked a good part of their pods as reclaimable.

Which issue(s) this PR fixes:

Fixes #3140

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix webook validation for batch/Job to allow partial admission of a Job to use all available resources.
It also fixes a scenario of partial re-admission when some of the Pods are already reclaimed.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[trasc]

/test all

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	74883ef
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66f6bce9ef50ee0008e8792d

[trasc]

/test all

[trasc]

/test pull-kueue-test-integration-main

[trasc]

/test pull-kueue-test-integration-main

[mimowo]

/lgtm
/approve
Thanks!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 01b5e92657b78d46473b01c225c59ab5f23dd8fc

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS [mimowo]
• test/OWNERS [mimowo,trasc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mimowo]

/release-note-edit

Fix webook validation for batch/Job to allow partial admission of a Job to use all available resources.
It also fixes a scenario of partial re-admission when some of the Pods are already reclaimed.

I think it better captures the fix from the end-user perspective.

[tenzen-y]

It seems that there is this bug in the release-0.8 as well:

• kueue/pkg/controller/jobs/job/job_webhook.go

  Line 181 in 910f7c4

  if !oldJob.IsSuspended() && ptr.Deref(oldJob.Spec.Parallelism, 1) != ptr.Deref(newJob.Spec.Parallelism, 1) {

• kueue/pkg/controller/jobs/job/job_controller.go

  Line 156 in 910f7c4

  return j.Spec.Suspend != nil && *j.Spec.Suspend && j.Annotations[StoppingAnnotation] != "true"

/cherry-pick release-0.8

[k8s-infra-cherrypick-robot]

@tenzen-y: #3152 failed to apply on top of branch "release-0.8":

Applying: Allow unsuspending a job with a parallelism equal or less then min.
Using index info to reconstruct a base tree...
M	pkg/controller/jobs/job/job_webhook_test.go
A	test/integration/webhook/jobs/job_webhook_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/integration/webhook/jobs/job_webhook_test.go deleted in HEAD and modified in Allow unsuspending a job with a parallelism equal or less then min.. Version Allow unsuspending a job with a parallelism equal or less then min. of test/integration/webhook/jobs/job_webhook_test.go left in tree.
Auto-merging pkg/controller/jobs/job/job_webhook_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow unsuspending a job with a parallelism equal or less then min.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

It seems that there is this bug in the release-0.8 as well:

• kueue/pkg/controller/jobs/job/job_webhook.go

  Line 181 in 910f7c4

  if !oldJob.IsSuspended() && ptr.Deref(oldJob.Spec.Parallelism, 1) != ptr.Deref(newJob.Spec.Parallelism, 1) {

• kueue/pkg/controller/jobs/job/job_controller.go

  Line 156 in 910f7c4

  return j.Spec.Suspend != nil && *j.Spec.Suspend && j.Annotations[StoppingAnnotation] != "true"

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mimowo]

Yeah there were a couple of bugs fixed for PartialAdmission. I think we need to cherry pick them all to make the feature work well , but I think it makes sense to do so

[tenzen-y]

Yeah there were a couple of bugs fixed for PartialAdmission. I think we need to cherry pick them all to make the feature work well , but I think it makes sense to do so

That makes sense. I am seeking PR history, which includes PartialAdmission bug fixes.

[tenzen-y]

Yeah there were a couple of bugs fixed for PartialAdmission. I think we need to cherry pick them all to make the feature work well , but I think it makes sense to do so

That makes sense. I am seeking PR history, which includes PartialAdmission bug fixes.

After I summarize all PRs at #3197, let's cherry-pick those to release 0.8.