Fix "Failed Pod can be replaced in group" e2e test. #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
/cc @trasc |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/test pull-kueue-test-integration-main https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/3148/pull-kueue-test-integration-main/1839330236475379712 should be solved by #3145. |
|
/test pull-kueue-test-integration-main Due to #3149. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 58b068862a2436b00dad31723bcf5d1958a0acc1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind flake
/kind failing-test
What this PR does / why we need it:
Fix "Failed Pod can be replaced in group" e2e test.
Which issue(s) this PR fixes:
Fixes #3147
Special notes for your reviewer:
Sometimes the garbage collector takes more than 5 seconds to delete a finalized Pod. We don't need to wait for the Pod to be removed after it's been replaced; we only need to confirm that the finalizer has been removed.
Does this PR introduce a user-facing change?