Graduate LendingLimit to Beta #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
release-note
macsko
force-pushed
the
graduate_lending_limit_to_beta
branch
from
b5603b2
to
79565c3
Compare
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
macsko
force-pushed
the
graduate_lending_limit_to_beta
branch
from
79565c3
to
ba1543e
Compare
macsko
force-pushed
the
graduate_lending_limit_to_beta
branch
from
ba1543e
to
5b12a50
Compare
|
/lgtm Thanks for promoting this. Once we can remove the false branch in 0.10, the codebase will be easier to understand/read :) |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c505ee05d53a2739d92d8f5231a58ebf9cd52b00
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, macsko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Got that, thanks for the work @macsko |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Graduate LendingLimit feature to beta and enable it by default.
Feature flag is now enabled by default also in the tests. Added new test cases to verify a cases when
LendingLimitfield is set without a feature flag enabled.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?