-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AdmissionCheckStrategy API, change assigning AdmissionCheck… #1960
Introduce AdmissionCheckStrategy API, change assigning AdmissionCheck… #1960
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
fecc083
to
c755404
Compare
/assign @alculquicondor |
/release-note-edit
|
The original note could have been interpreted as a breaking change, which is not the case. |
/release-note-edit
|
8237aa8
to
7c77a63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first path is added.
0992e5b
to
dbdc4a2
Compare
478a256
to
18dd2fa
Compare
/retest |
If the above error is a flaky, please open an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 2 nits
e03ee55
to
ccc1b3a
Compare
2da7665
to
81067e7
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, PBundyra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…s to a Workload Add validation webhook Add TestReconcile unit tests Add webhook unit tests Add an additional layer to the API that wraps rules for AdmissionChecks Add AdmissionCheckStrategy to ClusterQueues's cache Change ClusterQueue cache Sort AdmissionChecks in a Workload
81067e7
to
181cdca
Compare
/lgtm |
LGTM label has been added. Git tree hash: bbfb53bfb4792ccaa7d3d14764d98b4e2c9e1d78
|
Oops, this PR already has been merged :( |
@PBundyra Sorry for my late response. Could you address my comments? Thanks. |
…s to a Workload (kubernetes-sigs#1960) Add validation webhook Add TestReconcile unit tests Add webhook unit tests Add an additional layer to the API that wraps rules for AdmissionChecks Add AdmissionCheckStrategy to ClusterQueues's cache Change ClusterQueue cache Sort AdmissionChecks in a Workload
/release-note-edit
|
…s to a Workload
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements changes described in #1935
Which issue(s) this PR fixes:
Fixes #1432
Special notes for your reviewer:
I've tested it manually e2e. In an incoming PR I'll add webhook validation.
Does this PR introduce a user-facing change?