-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sigs.k8s.io/jobset from 0.3.2 to 0.4.0 #1785
Bump sigs.k8s.io/jobset from 0.3.2 to 0.4.0 #1785
Conversation
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold test failure look legit. mind if I look into it? I’d like to get more familiar with Jobset integration. |
Thank you for your help. |
/approve cancel |
I think something changed in the fake client - sigs.k8s.io/controller-runtime v0.17.0
+ sigs.k8s.io/controller-runtime v0.17.2 The Jobset integration might not have anything to do with it. |
If that's the case, could you try upgrading |
Or report a bug in controller-runtime, if the change in the fake client is not acceptable. |
I tried to update jobset without controller-runtime but it seems to want to update. I tried just bumping the |
we'll have to update controller-runtime at some point regardless, so try that separately first |
Please check this PR: kubernetes-sigs/controller-runtime#2681 |
/approve cancel |
Bumps [sigs.k8s.io/jobset](https://github.com/kubernetes-sigs/jobset) from 0.3.2 to 0.4.0. - [Release notes](https://github.com/kubernetes-sigs/jobset/releases) - [Changelog](https://github.com/kubernetes-sigs/jobset/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/jobset@v0.3.2...v0.4.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/jobset dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
4b20e7f
to
1b465d5
Compare
/hold cancel |
LGTM label has been added. Git tree hash: 3a834354cbfd248b3ed82f6b31dd0337c2aae814
|
/assign @tenzen-y |
/assign @alculquicondor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dependabot[bot], tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumps [sigs.k8s.io/jobset](https://github.com/kubernetes-sigs/jobset) from 0.3.2 to 0.4.0. - [Release notes](https://github.com/kubernetes-sigs/jobset/releases) - [Changelog](https://github.com/kubernetes-sigs/jobset/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/jobset@v0.3.2...v0.4.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/jobset dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps sigs.k8s.io/jobset from 0.3.2 to 0.4.0.
Release notes
Sourced from sigs.k8s.io/jobset's releases.
Commits
9f2cb14
Merge pull request #432 from danielvegamyhre/title55a38c0
update title and subtitlef70676c
Merge pull request #431 from kubernetes-sigs/dependabot/go_modules/kubernetes...cb29842
Bump the kubernetes group with 5 updates68e9aaa
Merge pull request #426 from googs1025/main70e6f9b
typo: Fix some commentsd0d32af
Merge pull request #424 from danielvegamyhre/docs-0.3.2b3c8776
update installation docs for v0.3.25f2220c
Merge pull request #421 from danielvegamyhre/val-err-msg15c24a3
add leader pot not scheduled info logDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)