Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ways to avoid users submitting workloads without any requests #3069

Open
1 of 3 tasks
kannon92 opened this issue Sep 16, 2024 · 6 comments
Open
1 of 3 tasks
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@kannon92
Copy link
Contributor

What would you like to be added:
We should add a doc to explain how to use ValidationAdmissionPolicy to optionally forbid users from submitting workloads without any requests.

This page should be updated to mention how one can use VAP to enforce workloads having requests.

Why is this needed:

Kueue tracks resource requests by the requests field in the PodTemplate. If one submits a workload without any requests specified, kueue will not report any resources used by this workload.

It would be worth mentioning this in the docs and provide an example to forbid this.
Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@kannon92 kannon92 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 16, 2024
@kannon92
Copy link
Contributor Author

/remove-kind feature
/kind docs
/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@kannon92:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-kind feature
/kind docs
/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

@kannon92: The label(s) kind/docs cannot be applied, because the repository doesn't have them.

In response to this:

/remove-kind feature
/kind docs
/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 16, 2024
@tenzen-y
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 17, 2024
@amitmaurya07
Copy link

Hi, I would like to work on this issue. Could you please assign this issue to me?

@mbobrovskyi
Copy link
Contributor

/assign @amitmaurya07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

No branches or pull requests

5 participants