Skip to content

Commit

Permalink
Review Remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
trasc committed Oct 23, 2024
1 parent 29835d4 commit a13f910
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions keps/3125-maximum-execution-time/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ if wl.Spec.MaximumExecutionTimeSeconds != nil {
}
```
- If `remainingTime` > 0 , a reconcile request should be queued with a `remainingTime` delay.
- If `remainingTime` <= 0 , the workload should be deactivated `wl.spec.Active = *false`, the `wl.status.accumulatedPastExecutionTimeSeconds` set to 0, and a relevant event recorded.
- If `remainingTime` <= 0 , the workload's deactivation is triggered, the `wl.status.accumulatedPastExecutionTimeSeconds` set to 0, and a relevant event recorded.

#### Jobs / Jobframework

Expand All @@ -148,13 +148,13 @@ Upon workload creation, the value from `kueue.x-k8s.io/max-exec-time-seconds` is

If specified, validate that the value of `wl.spec.maximumExecutionTimeSeconds` is greater then 0.

Optionally: `wl.spec.maximumExecutionTimeSeconds` is immutable [ while the workload is admitted ]
Validate that `wl.spec.maximumExecutionTimeSeconds` is immutable [ while the workload is admitted ]

#### Jobs

Validate that the value provided in the `kueue.x-k8s.io/max-exec-time-seconds` label is the base 10 representation of an integer greater then 0.

Optionally: The value of the `kueue.x-k8s.io/max-exec-time-seconds` label is immutable [ while the job is unsuspended ]
The value of the `kueue.x-k8s.io/max-exec-time-seconds` label is immutable [ while the job is unsuspended ]

### Test Plan

Expand Down

0 comments on commit a13f910

Please sign in to comment.