Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cilium hubble certgen Job and CronJob wrong args #9856

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Cilium hubble certgen Job and CronJob wrong args #9856

merged 1 commit into from
Mar 6, 2023

Conversation

XDRAGON2002
Copy link
Member

@XDRAGON2002 XDRAGON2002 commented Mar 4, 2023 •
edited by floryut
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR updates the arguments for cilium which have changed since v0.1.7.

Which issue(s) this PR fixes:

Fixes #9844

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?:

[Cilium] Updates hubble certgen arguments (wrong since v0.1.7)

@XDRAGON2002
update args
f3444cb 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 4, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @XDRAGON2002. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2023
@oomichi
Copy link
Contributor

oomichi commented Mar 5, 2023

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, XDRAGON2002

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2023
@yankay
Copy link
Member

yankay commented Mar 6, 2023

Thanks @XDRAGON2002
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1d9502e into kubernetes-sigs:master Mar 6, 2023
@floryut floryut added the kind/container-managers Containers section in the release note label Mar 6, 2023
@XDRAGON2002 XDRAGON2002 mentioned this pull request Mar 7, 2023
Closed
9 tasks
@prashantchitta prashantchitta mentioned this pull request Mar 8, 2023
Closed
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@XDRAGON2002 @HoKim98
update args (kubernetes-sigs#9856)
51d2107 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@XDRAGON2002 @HoKim98
update args (kubernetes-sigs#9856)
f32a89b 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
@prashantchitta prashantchitta mentioned this pull request Mar 8, 2023
Merged
oomichi pushed a commit to oomichi/kubespray that referenced this pull request Mar 9, 2023
@XDRAGON2002 @oomichi
update args (kubernetes-sigs#9856)
70dbfee 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
k8s-ci-robot pushed a commit that referenced this pull request Mar 9, 2023
@oomichi @XDRAGON2002
update args (#9856) (#9871)
3f41d8b 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
Co-authored-by: DRAGON2002 <81813720+XDRAGON2002@users.noreply.github.com>
@prashantchitta prashantchitta mentioned this pull request Mar 13, 2023
Closed
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@XDRAGON2002 @nolimitkun
update args (kubernetes-sigs#9856)
76537e3 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@XDRAGON2002 @pedromcpedro
update args (kubernetes-sigs#9856)
ed4e33a 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi Awaiting requested review from oomichi

@yankay yankay Awaiting requested review from yankay

Assignees

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cilium hubble certgen Job and CronJob wrong args
5 participants
@XDRAGON2002 @k8s-ci-robot @oomichi @yankay @floryut