-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodes in etc hosts after cluster scale #9837
Update nodes in etc hosts after cluster scale #9837
Conversation
Hi @zhan9san. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @yankay |
Thanks @zhan9san |
/lgtm |
Thanks for doing this. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi, zhan9san The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Add new nodes into /etc/hosts of current nodes after cluster scale with scale.yml.
Which issue(s) this PR fixes:
Fixes #9817
Special notes for your reviewer:
Combine
Hosts | create list from inventory
andHosts | populate inventory into hosts file
into one block with one condition, so ifpopulate_inventory_to_hosts_file
is false, there is no need to runHosts | create list from inventory
.Combine the localhost entries tasks into one block and add a variable
populate_localhost_entries_to_hosts_file
as a condition.It will save some time, Respect #9279.
The ssl certificate has been generated in dns_early stage.
The
setup
task is a time-consuming task, so there is no need to updateansible_fqdn
in dns_late stage.Does this PR introduce a user-facing change?: