Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to install ContainerD on any Linux Distributions #9827

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Add support to install ContainerD on any Linux Distributions #9827

merged 1 commit into from
Mar 6, 2023

Conversation

XDRAGON2002
Copy link
Member

@XDRAGON2002 XDRAGON2002 commented Feb 24, 2023 •
edited by floryut
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a new variable which will allow attempt to install kubespray on an unsupported distribution.

Which issue(s) this PR fixes:

Fixes #9808

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?:

Add support to install ContainerD on any Linux Distributions using new var `allow_unsupported_distribution_setup`

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @XDRAGON2002. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2023
@yankay
Copy link
Member

yankay commented Feb 24, 2023

Thanks @XDRAGON2002

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2023
oomichi
oomichi reviewed Feb 26, 2023
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.
Just few comments.

/cc @oomichi

roles/container-engine/containerd/defaults/main.yml Outdated Show resolved Hide resolved
roles/container-engine/containerd/tasks/main.yml Outdated Show resolved Hide resolved
@yankay
Copy link
Member

yankay commented Mar 2, 2023

HI @XDRAGON2002, would you please change the PR follow the reviews :-)

@XDRAGON2002
add flag
8ec0f97 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
@XDRAGON2002
Copy link
Member Author

@oomichi @yankay have made the requested changes, thanks for the review.

@oomichi
Copy link
Contributor

oomichi commented Mar 6, 2023

Thanks for updating.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, XDRAGON2002

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@yankay
Copy link
Member

yankay commented Mar 6, 2023

Thanks @XDRAGON2002
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 13c793f into kubernetes-sigs:master Mar 6, 2023
@XDRAGON2002 XDRAGON2002 mentioned this pull request Mar 7, 2023
Closed
9 tasks
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@XDRAGON2002 @HoKim98
add flag (kubernetes-sigs#9827)
6dc7adf 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@XDRAGON2002 @HoKim98
add flag (kubernetes-sigs#9827)
eb7cf62 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@XDRAGON2002 @nolimitkun
add flag (kubernetes-sigs#9827)
d7015b4 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
@ErikJiang ErikJiang mentioned this pull request Mar 20, 2023
Merged
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@XDRAGON2002 @pedromcpedro
add flag (kubernetes-sigs#9827)
e08a63b 
Signed-off-by: Anant Vijay <anantvijay3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to install ContainerD on any Linux Distributions
4 participants
@XDRAGON2002 @k8s-ci-robot @yankay @oomichi