Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable control plane load balancing for kube-vip #9785

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Enable control plane load balancing for kube-vip #9785

merged 1 commit into from
Feb 13, 2023

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented Feb 11, 2023

Signed-off-by: bo.jiang bo.jiang@daocloud.io

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add the kube_vip_lb_enable parameter so that kube-vip can enable control plane load balancing.
image

Which issue(s) this PR fixes:

Fixes #9715

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Enable control plane load balancing for kube-vip

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 11, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2023
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@oomichi
Copy link
Contributor

oomichi commented Feb 13, 2023

Nice work!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@yankay
Copy link
Member

yankay commented Feb 13, 2023

Thanks @ErikJiang
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6ff845a into kubernetes-sigs:master Feb 13, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@yankay yankay mentioned this pull request May 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-vip enable Control Plane Load-Balancing
4 participants