[2.13] Add Kubernetes hashes 1.18.9/1.17.12 and set default #6701
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -125,12 +125,17 @@ crictl_checksums: | |||
| # Checksums | |||
| kubelet_checksums: | |||
| arm: | |||
| v1.18.9: 24f7559fe5214b5f3b625ab035e29159441e6cfd248befbeb78b63e660fccd23 | |||
| v1.18.8: 831f50ea45384884c50395c288d493e75dd134a962dc95261ce122de5e6a17ec | |||
| v1.18.6: 5f8367f9f5de77c022ec5d0cd86e897b7a33318185eaadb7736033d8dabcdbdb | |||
There was a problem hiding this comment.
just a question: How to maintain versions on this list of version hashes?
This question comes because v1.18.7 is skipped.
/cc @oomichi
There was a problem hiding this comment.
1.18.7 is a NO-OP version as 1.18.7 was a buggy tag (as was 1.17.10) so we don't have hashes for it as it shouldn't be use at all (pointing to a beta version IIRC)
And to maintain it you have 2 scripts in script folder to get hashes from binary (even if it's only a shasum -a 256)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add new Kubernetes hashes and set default
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: