Add protectKernelDefaults option (default true) to kubelet config file #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/XS
not sure kubelet likes this setting. You'll need the kubelet logs to check what's wrong with it |
Damn, will check, switching this to WIP |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
floryut
force-pushed
the
kube-bench-firstpass
branch
from
710c5cd
to
1d1f228
Compare
k8s-ci-robot
added
size/S
floryut
force-pushed
the
kube-bench-firstpass
branch
from
1d1f228
to
5404d85
Compare
floryut
force-pushed
the
kube-bench-firstpass
branch
from
5404d85
to
9674618
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
need to remove the draft status to get merged |
weird, it is not but the WIP label wasn't remove |
floryut
changed the title
floryut
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Closed
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Sep 12, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: Add protectKernelDefaults option (default true) to kubelet config file (kubernetes-sigs#6611) Rotate kubelet server certificate. (kubernetes-sigs#6453) Add snapshot-controller for CSI drivers and snapshot CRDs, add a default volumesnapshotclass when running cinder CSI (kubernetes-sigs#6537) Calico: update crds to v1 and cr (kubernetes-sigs#6360) Fix E306 in roles/network_plugin (kubernetes-sigs#6516)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Fix one of the kube-bench error
Which issue(s) this PR fixes:
Partial #6595
Special notes for your reviewer:
4.2.6 Ensure that the --protect-kernel-defaults argument is set to trueDoes this PR introduce a user-facing change?: