Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback coredns, should not have been updated before 1.19 #6573

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Aug 21, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Jobs are starting to fail on upgrade, when reaching coredns, this is due to corefile-migration bundled with kubeadm not supporting coredns 1.6.7+
Rollback while still on 1.18

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2020
@EppO
Copy link
Contributor

EppO commented Aug 24, 2020

why was #6538 approved in the first place?

@floryut
Copy link
Member Author

floryut commented Aug 24, 2020

why was #6538 approved in the first place?

Approval frenzy 😄

@mattymo
Copy link
Contributor

mattymo commented Aug 26, 2020

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mattymo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1ff95e8 into kubernetes-sigs:master Aug 26, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants