Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Set Cgroup driver by default to systemd #6563

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Docker: Set Cgroup driver by default to systemd #6563

merged 3 commits into from
Aug 31, 2020

Conversation

bmelbourne
Copy link
Contributor

@bmelbourne bmelbourne commented Aug 20, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
This change is required to align with the official Kubernetes recommendation to use systemd as the Docker Cgroup driver for both the container runtime and kubelet to stabilize the allocation of resources to processes.

https://kubernetes.io/docs/setup/production-environment/container-runtimes/#cgroup-drivers

Which issue(s) this PR fixes:
Fixes #5134

Special notes for your reviewer:
Before working on the user documentation, I'm seeking initial feedback on the implementation.

I also believe that we should just document and advise user's of lnykryn/systemd-rhel#266 and ensure responsibility of addressing Linux OS issues, such as dbus, systemd, etc continues to be with the DevOps / Platform Engineers and the cloud providers via prebuilt images, AMIs, etc.

Whilst it's important to ensure the relevant OS packages are installed prior to deploying Kubespray, by trying to mitigate every possible Linux OS issue would result in over-engineering the solution, which may introduce unknown consequences and constraints for our users.

Does this PR introduce a user-facing change?:

Docker: Set cgroup driver by default to systemd

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bmelbourne. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 20, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2020
@bmelbourne bmelbourne changed the title [WIP] Set Docker Cgroup driver to systemd [WIP] Docker: Set Cgroup driver by default to systemd Aug 21, 2020
@bmelbourne
Copy link
Contributor Author

/assign @chadswen

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Aug 27, 2020

@bmelbourne it looks like this PR is mixing some changes around webhooks as well? maybe those things should be split?

@bmelbourne
Copy link
Contributor Author

bmelbourne commented Aug 27, 2020

@bmelbourne it looks like this PR is mixing some changes around webhooks as well? maybe those things should be split?

@Miouge1
Those are not my changes...they have been included as part of rebase merge somehow.

I've been asked on a regular basis to do this before the PR will be reviewed and this appears to be the consequence??

$ git pull --rebase upstream master

If this is the incorrect approach, just let me know how the rebase should be achieved as I've not been able to find anything in the docs. I found the command from the CI test jobs.

FYI there is a drop-down at the top-left of the Files changed page where you can filter just on my single commit.

Maybe the approach should be as follows to avoid replaying all commits on this branch?

$ git checkout master
$ git fetch upstream
$ git rebase upstream/master
$ git push origin master
$ git checkout set-docker-cgroup-driver-systemd
$ git pull origin master

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2020
@bmelbourne bmelbourne closed this Aug 27, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 27, 2020
@bmelbourne
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Aug 27, 2020
@k8s-ci-robot
Copy link
Contributor

@bmelbourne: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2020
@bmelbourne bmelbourne changed the title [WIP] Docker: Set Cgroup driver by default to systemd Docker: Set Cgroup driver by default to systemd Aug 29, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Aug 31, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmelbourne, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@floryut
Copy link
Member

floryut commented Aug 31, 2020

No reason not to merge this, nice 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 03c9c09 into kubernetes-sigs:master Aug 31, 2020
@bmelbourne bmelbourne deleted the set-docker-cgroup-driver-systemd branch September 1, 2020 08:51
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 15, 2021
* Set Docker Cgroup driver to systemd

* Add docker_cgroup_driver in Docker defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use systemd cgroup driver for Docker on systemd systems (not only RedHat)
6 participants