-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Set Cgroup driver by default to systemd #6563
Docker: Set Cgroup driver by default to systemd #6563
Conversation
Hi @bmelbourne. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @chadswen |
@bmelbourne it looks like this PR is mixing some changes around webhooks as well? maybe those things should be split? |
@Miouge1 I've been asked on a regular basis to do this before the PR will be reviewed and this appears to be the consequence??
If this is the incorrect approach, just let me know how the FYI there is a drop-down at the top-left of the Maybe the approach should be as follows to avoid replaying all commits on this branch?
|
/reopen |
@bmelbourne: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmelbourne, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No reason not to merge this, nice 👍 |
* Set Docker Cgroup driver to systemd * Add docker_cgroup_driver in Docker defaults
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change is required to align with the official Kubernetes recommendation to use
systemd
as the Docker Cgroup driver for both the container runtime and kubelet to stabilize the allocation of resources to processes.https://kubernetes.io/docs/setup/production-environment/container-runtimes/#cgroup-drivers
Which issue(s) this PR fixes:
Fixes #5134
Special notes for your reviewer:
Before working on the user documentation, I'm seeking initial feedback on the implementation.
I also believe that we should just document and advise user's of lnykryn/systemd-rhel#266 and ensure responsibility of addressing Linux OS issues, such as dbus, systemd, etc continues to be with the DevOps / Platform Engineers and the cloud providers via prebuilt images, AMIs, etc.
Whilst it's important to ensure the relevant OS packages are installed prior to deploying Kubespray, by trying to mitigate every possible Linux OS issue would result in over-engineering the solution, which may introduce unknown consequences and constraints for our users.
Does this PR introduce a user-facing change?: