Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Openstack] Make it possible to open additional ports on masters #6547

Merged
merged 1 commit into from
Aug 27, 2020
Merged

[Openstack] Make it possible to open additional ports on masters #6547

merged 1 commit into from
Aug 27, 2020

Conversation

huxcrux
Copy link

@huxcrux huxcrux commented Aug 17, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR makes it ossible to open additional ports on master nodes. By default no additional ports are opend and I would not recommend to use this feature unless you know what you are doing.

Which issue(s) this PR fixes:

Fixes N/A

Special notes for your reviewer:
This PR does work 100% alongside the already existing "k8s_allowed_remote_ips" variable

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bl0m1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2020
@floryut
Copy link
Member

floryut commented Aug 17, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2020
@huxcrux
Copy link
Author

huxcrux commented Aug 17, 2020

/assign @Miouge1

@floryut
Copy link
Member

floryut commented Aug 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Aug 27, 2020

/approve

Thank you @bl0m1 !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bl0m1, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@floryut floryut mentioned this pull request Aug 27, 2020
Closed
@k8s-ci-robot k8s-ci-robot merged commit 2f8fc92 into kubernetes-sigs:master Aug 27, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 11, 2021
@LuckySB
make it possible to open additional ports on master nodes (kubernetes…
3e3deee 
…-sigs#6547)
zonca added a commit to zonca/jetstream_kubespray that referenced this pull request Jan 20, 2021
@zonca
Document the terraform option master_allowed_ports
1258ebf 
Implemented in kubernetes-sigs#6547
@zonca zonca mentioned this pull request Jan 20, 2021
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jan 21, 2021
@zonca
Document the terraform option master_allowed_ports (#7196)
24ceee1 
Implemented in #6547
khanhngobackend pushed a commit to khanhngobackend/kubespray that referenced this pull request Jan 22, 2021
@zonca
Document the terraform option master_allowed_ports (kubernetes-sigs…
a495d65 
…#7196)

Implemented in kubernetes-sigs#6547
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Feb 2, 2021
@zonca @LuckySB
Document the terraform option master_allowed_ports (kubernetes-sigs…
c55ee94 
…#7196)

Implemented in kubernetes-sigs#6547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@floryut floryut Awaiting requested review from floryut

Assignees

@Miouge1 Miouge1

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huxcrux @k8s-ci-robot @floryut @Miouge1