Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for 'setting up your first cluster' #6544

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Add docs for 'setting up your first cluster' #6544

merged 1 commit into from
Aug 21, 2020

Conversation

Svendegroote91
Copy link
Contributor

@Svendegroote91 Svendegroote91 commented Aug 17, 2020

What type of PR is this?
/kind documentation

What this PR does / why we need it:
By providing a hands-on step-by-step example, people will get familiar Kubespray more easily.

Which issue(s) this PR fixes:
Fixes #6543

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 17, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 17, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @Svendegroote91!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Svendegroote91. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 17, 2020
@floryut
Copy link
Member

floryut commented Aug 17, 2020

@Svendegroote91 Thank you for the PR, could you please check CLA ?
Also please take a look at markdown and yaml linters

@floryut
Copy link
Member

floryut commented Aug 17, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2020
@Svendegroote91
Copy link
Contributor Author

@Svendegroote91 Thank you for the PR, could you please check CLA ?
Also please take a look at markdown and yaml linters

Working on that :-)

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 17, 2020
@Svendegroote91
Copy link
Contributor Author

User updated for CLA

@hafe
Copy link
Contributor

hafe commented Aug 18, 2020

Would it be possible to use/change the existing sample inventory? This PR contains yet another sample inventory to maintain

@Svendegroote91
Copy link
Contributor Author

Svendegroote91 commented Aug 18, 2020

Would it be possible to use/change the existing sample inventory? This PR contains yet another sample inventory to maintain

You mean the current sample inventory.ini? I would propose to change that file since the general documentation refers to yaml files whilst this is still .ini, or would that have impact on other parts of the code that leverage this sample inventory file?

@hafe
Copy link
Contributor

hafe commented Aug 18, 2020

To me it seems very abundant and overwhelming to add all those variables that already should have decent default values in the roles. Why not just add deviations from default values?

@Svendegroote91
Copy link
Contributor Author

Svendegroote91 commented Aug 18, 2020

I removed the extra files and mentioned the deviations in text.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 18, 2020
@Svendegroote91
Copy link
Contributor Author

Any tip on the failing pipeline step?
It was not failing before, so I might have been unlucky this time?
It would surprise me if a markdown file would fail the actual code and build tests.

fatal: [instance-2]: FAILED! => {"attempts": 10, "changed": true, "cmd": "/usr/local/bin/etcdctl member add etcd3 --peer-urls=https://172.30.72.46:2380", "delta": "0:00:00.041774", "end": "2020-08-19 13:04:36.620176", "msg": "non-zero return code", "rc": 1, "start": "2020-08-19 13:04:36.578402", "stderr": "{\"level\":\"warn\",\"ts\":\"2020-08-19T13:04:36.618Z\",\"caller\":\"clientv3/retry_interceptor.go:61\",\"msg\":\"retrying of unary invoker failed\",\"target\":\"endpoint://client-7a0017d4-0f47-4248-8330-bebfedb9a6f8/172.30.72.47:2379\",\"attempt\":0,\"error\":\"rpc error: code = FailedPrecondition desc = etcdserver: Peer URLs already exists\"}\nError: etcdserver: Peer URLs already exists", "stderr_lines": ["{\"level\":\"warn\",\"ts\":\"2020-08-19T13:04:36.618Z\",\"caller\":\"clientv3/retry_interceptor.go:61\",\"msg\":\"retrying of unary invoker failed\",\"target\":\"endpoint://client-7a0017d4-0f47-4248-8330-bebfedb9a6f8/172.30.72.47:2379\",\"attempt\":0,\"error\":\"rpc error: code = FailedPrecondition desc = etcdserver: Peer URLs already exists\"}", "Error: etcdserver: Peer URLs already exists"], "stdout": "", "stdout_lines": []}

@woopstar
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Svendegroote91, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit f204212 into kubernetes-sigs:master Aug 21, 2020
@floryut floryut mentioned this pull request Aug 21, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra hands-on documentation for 'setting up your first cluster'
5 participants