-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for 'setting up your first cluster' #6544
Add docs for 'setting up your first cluster' #6544
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @Svendegroote91! |
Hi @Svendegroote91. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Svendegroote91 Thank you for the PR, could you please check CLA ? |
/ok-to-test |
Working on that :-) |
User updated for CLA |
Would it be possible to use/change the existing sample inventory? This PR contains yet another sample inventory to maintain |
You mean the current sample inventory.ini? I would propose to change that file since the general documentation refers to yaml files whilst this is still .ini, or would that have impact on other parts of the code that leverage this sample inventory file? |
To me it seems very abundant and overwhelming to add all those variables that already should have decent default values in the roles. Why not just add deviations from default values? |
I removed the extra files and mentioned the deviations in text. |
Any tip on the failing pipeline step?
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Svendegroote91, woopstar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
By providing a hands-on step-by-step example, people will get familiar Kubespray more easily.
Which issue(s) this PR fixes:
Fixes #6543
Special notes for your reviewer:
Does this PR introduce a user-facing change?: