-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed fedora modular repos activation for fcos #6300
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @hardoverflow! |
Hi @hardoverflow. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hardoverflow Thank you for the PR; Can you sign CLA ? |
Done. |
/check-cla |
Please re-check CLA. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fcos
provides with latest stable stream f32
and reshaped the repos.
I can approve current solution. I forgot to send PR with similar solution
- name: Enable modular repos for CRI-O
ini_file:
path: "/etc/yum.repos.d/{{ item.repo }}.repo"
section: "{{ item.section }}"
option: enabled
value: 1
become: true
when: is_ostree
loop:
- repo: "fedora-updates-modular"
section: "updates-modular"
- repo: "fedora-modular"
section: "fedora-modular"
Nice. I will modify the code with your change and commit again. Thank you! |
ok all good then, thank you @spaced |
Kubespray CI - yamllint job status report is jammed, tried to retry it couple of times, always succeeds but still not showing up green in github |
Ok indeed, we'll see when the approval kick in if the pipeline manage to get back in shape |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardoverflow, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* 'master' of https://github.com/kubernetes-sigs/kubespray: Add a way to deploy cilium alongside another CNI (kubernetes-sigs#6373) Cleanup old build-cephfs-provisioner.yml playbook (kubernetes-sigs#6418) Always enable GitLab CI artifacts for cluster-dump (kubernetes-sigs#6412) Remove allow-release-candidate-upgrades already include in experimental-upgrades flag (kubernetes-sigs#6349) add calico-node selinux (kubernetes-sigs#6359) Add oomichi to reviwers of MetalLB addon (kubernetes-sigs#6393) Respect kube_override_hostname during removal/upgrade (kubernetes-sigs#6347) Fixed fedora modular repos activation for fcos (kubernetes-sigs#6300) Fix kube-proxy post deployment removal (kubernetes-sigs#5554) Remove old csi-attacher flag and fix RBAC for Cinder CSI (kubernetes-sigs#6358) Update cilium minimum kernel preinstall check (kubernetes-sigs#6376) Add readiness probe to dns-autoscaler (kubernetes-sigs#6382) Add Fedora CoreOS kubevirt image for tests (kubernetes-sigs#6337) allow kubeadm to upgrade etcd (kubernetes-sigs#6345) crio: harden downloads with retry (kubernetes-sigs#6374) Add workaround with include_task for mitogen (kubernetes-sigs#6312)
* Enable fedora modular repos for fcos kubernetes-sigs#6299 * Fixed fedora modular repos activation for fcos kubernetes-sigs#6300
What type of PR is this?
/kind bug
What this PR does / why we need it:
The problem fixes a bug when activating the fedora-modular repositories in Fedora CoreOS.
Which issue(s) this PR fixes:
#6299
Special notes for your reviewer:
This works for me. But I'd love some other people to poke at it before merging this.
Does this PR introduce a user-facing change?: