Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13] Backport recent bugfixes and mainly docker-cli issue #6179

Merged
merged 9 commits into from
May 22, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented May 21, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Backport docker-cli fixes to allow upgrade jobs in master branch.
Disable upgrade jobs with 2.12

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
Fixes backported

  • Reorder test (required, allow merge in ci)
  • Ubuntu skip in molecule (required, CI jobs failing if not)
  • Kubernetes-dashboard template error (optional, "critical" dashboard bug)
  • Disable ovh CI (required, OVH key/sub is no longer valid)
  • Kubernetes-dashboard template missing (optional)
  • Api server not using variable (optional, "critical" bug)
  • docker-cli (required, this is the needed one ^^)

And remove auto run of upgrade jobs, as 2.12 as the docker-cli issue also

Does this PR introduce a user-facing change?:

Backport #6066
Backport #6107 
Backport #6136 
Fix docker-cli issue

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 21, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 21, 2020
floryut and others added 6 commits May 21, 2020 22:38
The 98e7a07 commit udpates the
dashboard version to 2.0.0 but it enable skip login flag wasn't
updated. This change updates its identation to avoid issues when
dashboard_skip_login is enabled.
…kubernetes-sigs#6107)

* Create namespace when dashboard deployment uses customized namespace.

* Fix syntax.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 22, 2020
@Atoms
Copy link
Member

Atoms commented May 22, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Atoms, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1f4ef0e into kubernetes-sigs:release-2.13 May 22, 2020
oomichi pushed a commit to oomichi/try-kubernetes that referenced this pull request May 22, 2020
because kubernetes-sigs/kubespray#6179 has
been merged into Kubespray release-2.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants