-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.13] Backport recent bugfixes and mainly docker-cli issue #6179
[2.13] Backport recent bugfixes and mainly docker-cli issue #6179
Conversation
The 98e7a07 commit udpates the dashboard version to 2.0.0 but it enable skip login flag wasn't updated. This change updates its identation to avoid issues when dashboard_skip_login is enabled.
…kubernetes-sigs#6107) * Create namespace when dashboard deployment uses customized namespace. * Fix syntax.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Atoms, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
because kubernetes-sigs/kubespray#6179 has been merged into Kubespray release-2.13
What type of PR is this?
/kind bug
What this PR does / why we need it:
Backport docker-cli fixes to allow upgrade jobs in master branch.
Disable upgrade jobs with 2.12
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Fixes backported
And remove auto run of upgrade jobs, as 2.12 as the docker-cli issue also
Does this PR introduce a user-facing change?: