Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom dashboard namespace test #6134

Closed
wants to merge 2 commits into from
Closed

Add custom dashboard namespace test #6134

wants to merge 2 commits into from

Conversation

p37ruh4
Copy link
Contributor

@p37ruh4 p37ruh4 commented May 13, 2020

Related to #6098 and requested by @floryut here: #6107 (comment)

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature

/kind flake

What this PR does / why we need it:
Adds custom dashboard naming test

Which issue(s) this PR fixes:

Does not fix the issue but is related to #6098

Special notes for your reviewer:
@floryut wanted to add this test #6107 (comment)

Does this PR introduce a user-facing change?:

NONE

Add custom dashboard namespace test to test scenario when non-default dashboard namespace is used
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @p37ruh4. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: p37ruh4
To complete the pull request process, please assign ant31
You can assign the PR to them by writing /assign @ant31 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2020
@p37ruh4
Copy link
Contributor Author

p37ruh4 commented May 13, 2020

Replaces #6133 as I had issues ammending previous commit message.

@LuckySB
Copy link
Contributor

LuckySB commented May 13, 2020

/ok-to-test
/need-rebase

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2020
@floryut
Copy link
Member

floryut commented May 27, 2020

@p37ruh4 Your git history seems weird, please rebase master and only put your commit (no merge commit, rebase only)

@floryut
Copy link
Member

floryut commented Jun 9, 2020

@p37ruh4 Are you still around ?

@p37ruh4
Copy link
Contributor Author

p37ruh4 commented Jun 9, 2020

@floryut, I will create new pull request as this one has both merge conflicts and is outdated.

@p37ruh4 p37ruh4 closed this Jun 9, 2020
@p37ruh4 p37ruh4 deleted the patch-2 branch June 9, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants