-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom dashboard namespace test #6134
Conversation
Add custom dashboard namespace test to test scenario when non-default dashboard namespace is used
Hi @p37ruh4. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: p37ruh4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Replaces #6133 as I had issues ammending previous commit message. |
/ok-to-test |
@p37ruh4 Your git history seems weird, please rebase master and only put your commit (no merge commit, rebase only) |
@p37ruh4 Are you still around ? |
@floryut, I will create new pull request as this one has both merge conflicts and is outdated. |
Related to #6098 and requested by @floryut here: #6107 (comment)
What type of PR is this?
What this PR does / why we need it:
Adds custom dashboard naming test
Which issue(s) this PR fixes:
Does not fix the issue but is related to #6098
Special notes for your reviewer:
@floryut wanted to add this test #6107 (comment)
Does this PR introduce a user-facing change?: